Update jgdas atmos verfozn and verfrad with COMIN/COMOUT prefix instead of COM #3342
Conversation
mingshichen-noaa
requested review from
aerorahul,
WalterKolczynski-NOAA and
KateFriedman-NOAA
and removed request for
EdwardSafford-NOAA
jobs/JGDAS_ATMOS_VERFOZN
Outdated
|
|
||
| export oznstat="${COM_ATMOS_ANALYSIS}/gdas.t${cyc}z.oznstat" | ||
| export TANKverf_ozn=${TANKverf_ozn:-${COM_ATMOS_OZNMON}} | ||
| export oznstat="${COMOUT_ATMOS_ANALYSIS}/gdas.t${cyc}z.oznstat" |
There was a problem hiding this comment.
COMOUT_ATMOS_ANALYSIS should be a COMIN. This is setting the path of an input file (oznstat) for the GSI monitoring package.
There was a problem hiding this comment.
Yes, I agree with your comments. Have modified them.
jobs/JGDAS_ATMOS_VERFRAD
Outdated
| if [[ ! -d ${TANKverf_rad} ]]; then mkdir -p -m 775 ${TANKverf_rad} ; fi | ||
| if [[ ! -d ${TANKverf_radM1} ]]; then mkdir -p -m 775 ${TANKverf_radM1} ; fi | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | ||
| COMOUT_ATMOS_ANALYSIS:COM_ATMOS_ANALYSIS_TMPL |
There was a problem hiding this comment.
Same as other comment, COMOUT_ATMOS_ANALYSIS should be a COMIN.
There was a problem hiding this comment.
Yes, I agree with your suggestion. modified them.
|
@KateFriedman-NOAA |
|
@mingshichen-noaa Please address my review comments and then we can proceed to automated CI testing. Thanks and thanks for confirming CI worked on Hercules for you. |
|
@KateFriedman-NOAA |
Description
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global JGDAS_ATMOS_VERFOZN and JGDAS_ATMOS_VERFRAD jobs and associated bash and python scripts
Refs #2451
Type of change
Change characteristics
How has this been tested?
Checklist