Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce messaging to GitHub in Jenkins Pipeline #2369

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

Description

This PR updates the Jenkins Pipeline code with safeguards against the errors caused when Jenkins fails to authenticate with GitHub to message or update a label. This was achieved simply by:

  • Reducing the number out messages sent to the GitHub PR
  • Putting try blocks around most of the update label calls

Type of change

  • Bug fix (fixes something broken)
    The Pipeline continued to to fail due short network connection issues
    when trying to authenticate the updates of GitHub labels.

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

This was tested on Hera with a full run-through without interruptions without any errors.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added the CI/CD Issue related to CI/CD label Mar 1, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA changed the title reduce messaging to GitHub in Jenkins Pipeline (fixes authentication errors) Reduce messaging to GitHub in Jenkins Pipeline Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Issue related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant