Skip to content

Commit

Permalink
Merge branch 'NOAA-EMC:develop' into feature/gocart_emission_update
Browse files Browse the repository at this point in the history
  • Loading branch information
bbakernoaa authored Jan 23, 2024
2 parents 0ce844e + f4d187f commit 6af1d45
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 3 deletions.
2 changes: 2 additions & 0 deletions env/HERA.env
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export npe_node_max=40
export launcher="srun -l --export=ALL"
export mpmd_opt="--multi-prog --output=mpmd.%j.%t.out"

#export POSTAMBLE_CMD='report-mem'

# Configure MPI environment
#export I_MPI_ADJUST_ALLREDUCE=5
#export MPI_BUFS_PER_PROC=2048
Expand Down
2 changes: 1 addition & 1 deletion parm/config/gfs/config.prepoceanobs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ echo "BEGIN: config.prepoceanobs"
export OCNOBS2IODAEXEC=${HOMEgfs}/sorc/gdas.cd/build/bin/gdas_obsprovider2ioda.x

export OBS_YAML_DIR=${HOMEgfs}/sorc/gdas.cd/parm/soca/obs/config
export OBSPROC_YAML=@OBSPROC_YAML@
export OBSPREP_YAML=@OBSPREP_YAML@
export OBS_LIST=@SOCA_OBS_LIST@
[[ -n "${OBS_LIST}" ]] || export OBS_LIST=${HOMEgfs}/sorc/gdas.cd/parm/soca/obs/obs_list.yaml
export OBS_YAML=${OBS_LIST}
Expand Down
2 changes: 1 addition & 1 deletion sorc/gdas.cd
Submodule gdas.cd updated 32 files
+12 −0 parm/ioda/bufr2ioda/bufr2ioda_bathythermal_profiles.json
+1 −1 parm/ioda/bufr2ioda/bufr2ioda_subpfl_argo_profiles.json
+12 −0 parm/ioda/bufr2ioda/bufr2ioda_subpfl_glider_profiles.json
+12 −0 parm/ioda/bufr2ioda/bufr2ioda_tesac_mammals_profiles.json
+12 −0 parm/ioda/bufr2ioda/bufr2ioda_tesac_profiles.json
+12 −0 parm/ioda/bufr2ioda/bufr2ioda_trackob_surface.json
+12 −0 parm/ioda/bufr2ioda/bufr2ioda_xbtctd_profiles.json
+0 −0 parm/soca/berror/old/soca_bump2d.yaml
+0 −0 parm/soca/berror/old/soca_bump_split.yaml
+22 −12 parm/soca/berror/saber_blocks.yaml
+37 −0 parm/soca/berror/soca_parameters_diffusion_hz.yaml
+30 −0 parm/soca/berror/soca_parameters_diffusion_vt.yaml
+1 −25 parm/soca/berror/soca_setcorscales.yaml
+41 −0 parm/soca/obsprep/obsprep_config.yaml
+0 −41 parm/soca/obsproc/obsproc_config.yaml
+24 −0 scripts/exgdas_global_marine_analysis_bmat.sh
+27 −0 scripts/exgdas_global_marine_analysis_prep.py
+23 −18 scripts/exglobal_prep_ocean_obs.py
+5 −5 test/soca/gw/CMakeLists.txt
+2 −2 test/soca/gw/run_jjobs.yaml.test
+1 −1 test/soca/gw/setup_obsprep.sh
+1 −1 ush/eva/marine_eva_post.py
+3 −0 ush/eva/marine_gdas_plots.yaml
+272 −0 ush/ioda/bufr2ioda/bufr2ioda_altkob_surface.py
+267 −0 ush/ioda/bufr2ioda/bufr2ioda_bathythermal_profiles.py
+25 −31 ush/ioda/bufr2ioda/bufr2ioda_subpfl_argo_profiles.py
+318 −0 ush/ioda/bufr2ioda/bufr2ioda_subpfl_glider_profiles.py
+312 −0 ush/ioda/bufr2ioda/bufr2ioda_tesac_mammals_profiles.py
+312 −0 ush/ioda/bufr2ioda/bufr2ioda_tesac_profiles.py
+274 −0 ush/ioda/bufr2ioda/bufr2ioda_trackob_surface.py
+293 −0 ush/ioda/bufr2ioda/bufr2ioda_xbtctd_profiles.py
+3 −3 ush/soca/prep_marine_obs.py
20 changes: 20 additions & 0 deletions ush/preamble.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
# TRACE (YES/NO): Whether to echo every command (set -x) [default: "YES"]
# STRICT (YES/NO): Whether to exit immediately on error or undefined variable
# (set -eu) [default: "YES"]
# POSTAMBLE_CMD (empty/set): A command to run at the end of the job
# [default: empty]
#
#######
set +x
Expand Down Expand Up @@ -70,6 +72,24 @@ postamble() {
start_time="${2}"
rc="${3}"

# Execute postamble command
#
# Commands can be added to the postamble by appending them to $POSTAMBLE_CMD:
# POSTAMBLE_CMD="new_thing; ${POSTAMBLE_CMD:-}" # (before existing commands)
# POSTAMBLE_CMD="${POSTAMBLE_CMD:-}; new_thing" # (after existing commands)
#
# Always use this form so previous POSTAMBLE_CMD are not overwritten. This should
# only be used for commands that execute conditionally (i.e. on certain machines
# or jobs). Global changes should just be added to this function.
# These commands will be called when EACH SCRIPT terminates, so be mindful. Please
# consult with global-workflow CMs about permanent changes to $POSTAMBLE_CMD or
# this postamble function.
#

if [[ -v 'POSTAMBLE_CMD' ]]; then
${POSTAMBLE_CMD}
fi

# Calculate the elapsed time
end_time=$(date +%s)
end_time_human=$(date -d@"${end_time}" -u +%H:%M:%S)
Expand Down
3 changes: 2 additions & 1 deletion workflow/rocoto/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from applications.applications import AppConfig
import rocoto.rocoto as rocoto
from wxflow import Template, TemplateConstants, to_timedelta
from typing import List

__all__ = ['Tasks']

Expand Down Expand Up @@ -124,7 +125,7 @@ def _template_to_rocoto_cycstring(self, template: str, subs_dict: dict = {}) ->
rocoto_conversion_dict.get)

@staticmethod
def _get_forecast_hours(cdump, config) -> list[str]:
def _get_forecast_hours(cdump, config) -> List[str]:
fhmin = config['FHMIN']
fhmax = config['FHMAX']
fhout = config['FHOUT']
Expand Down

0 comments on commit 6af1d45

Please sign in to comment.