Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change grib2 number of ULWRF from NCEP local definition to WMO definition in fv3lam_rrfs.xml #868

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

AndrewBenjamin-NOAA
Copy link
Contributor

@AndrewBenjamin-NOAA AndrewBenjamin-NOAA commented Jan 31, 2024

In order to use the WMO ID for ULWRF, I have removed <table_info>NCEP</table_info> from fv3lam_rrfs.xml.
This is needed for WMO headers for special FAA grib2 files.

A standalone test was performed on WCOSS2 and can be found here: /lfs/h2/emc/ptmp/andrew.benjamin/post_rrfs_2023062800.65061

Comparing the text files degrib2.ulwrf.test.out with degrib2.ulwrf.rrfsa.out show that removing the table info has the desired effect of using the WMO ID rather than the duplicate ID.

…MO ID rather than the dupilcate NCEP local use ID
@AndrewBenjamin-NOAA AndrewBenjamin-NOAA changed the title Removed <table_info>NCEP</table_info> for ULWRF in ls Removed <table_info>NCEP</table_info> for ULWRF in fv3lam_rrfs.xml Jan 31, 2024
@WenMeng-NOAA
Copy link
Collaborator

@AndrewBenjamin-NOAA Do you have an UPP issue linking to this PR?

@WenMeng-NOAA
Copy link
Collaborator

@AndrewBenjamin-NOAA Please sync your branch with the latest UPP develop.

@WenMeng-NOAA WenMeng-NOAA changed the title Removed <table_info>NCEP</table_info> for ULWRF in fv3lam_rrfs.xml Change grib2 number of ULWRF from NCEP local definition to WMO definition in fv3lam_rrfs.xml Feb 1, 2024
@AndrewBenjamin-NOAA
Copy link
Contributor Author

@AndrewBenjamin-NOAA Do you have an UPP issue linking to this PR?

@WenMeng-NOAA I do not have a UPP issue with this PR. This is part of a larger effort to no longer use duplicate NCEP local use IDs when official WMO id's have been added to the grib tables. This commit should be the last for products that go out over the SBN. I will do a similar check on all RRFS products currently running in the parallel. Would you like me to open a UPP issues?

@AndrewBenjamin-NOAA Please sync your branch with the latest UPP develop.

My branch has been synced with the latest UPP develop.

@WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA I do not have a UPP issue with this PR. This is part of a larger effort to no longer use duplicate NCEP local use IDs when official WMO id's have been added to the grib tables. This commit should be the last for products that go out over the SBN. I will do a similar check on all RRFS products currently running in the parallel. Would you like me to open a UPP issues?

@AndrewBenjamin-NOAA Please open a new UPP issue for this PR.

@WenMeng-NOAA WenMeng-NOAA added Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. labels Feb 1, 2024
@AndrewBenjamin-NOAA
Copy link
Contributor Author

@WenMeng-NOAA is it possible to reopen issue #826? These changes are directly related to this issue.

@WenMeng-NOAA WenMeng-NOAA linked an issue Feb 1, 2024 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2, Hera and Orion. There will be baseline re-creation for fv3r and 3drtma with this PR. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 2953e46 into NOAA-EMC:develop Feb 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change grib2 name of ULWRF in RRFS products
2 participants