Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Up UPP control files for SFS development #862

Merged
merged 15 commits into from
Mar 4, 2024

Conversation

KarinaAsmar-NOAA
Copy link
Contributor

@KarinaAsmar-NOAA KarinaAsmar-NOAA commented Jan 25, 2024

  • Adds SFS control files that generate products from initial version of SFS list (388 fields). Follows from UPP issue #845
  • Remove the hard-wired 12-hour bucket for after F240

@WenMeng-NOAA WenMeng-NOAA changed the title Add SFS Control Files - 388 fields Set Up UPP control files for SFS development Jan 25, 2024
@WenMeng-NOAA WenMeng-NOAA linked an issue Jan 25, 2024 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA linked an issue Jan 25, 2024 that may be closed by this pull request
@KarinaAsmar-NOAA
Copy link
Contributor Author

@WenMeng-NOAA Please see questions below regarding some of the CPC requested variables:

200-hPa velocity potential: UPP currently does not produce this variable, but it is in the NCEP GRIB2 tables as VPOT (Discipline 0, Category 2, Parameter 5). Since this addition requires modifying post_avblflds.xml, should it be included in this PR?

subsurface runoff ("drain" in Noah-MP Land Surface Model: The closest variable found in UPP is an accumulated value (ID 122: Accumulated storm surface runoff). Is this the appropriate field?

Total sky downward direct radiation at the surface: UPP does not show any variables of this sort. NCEP GRIB2 Table 4.2-0-4 has some options for downward radiation. Would any of those qualify for this request?

The remaining CPC requested variables are in UPP and are being added to the control files: IDs 20 (vertical velocity), 86 (streamfunction), and 162 (helicity).

@KarinaAsmar-NOAA
Copy link
Contributor Author

The following CPC requested variables have been added to the control files and tested: VVEL (id 20), STRM (id 86), HLCY (162).

Hera
standalone test: /scratch1/NCEPDEV/stmp2/Karina.Asmar/sfs_standalone/post_sfs_1991052100
regression test: /scratch1/NCEPDEV/stmp2/Karina.Asmar/regression_tests/rt_upp_sfs

WCOSS2
standalone test: /lfs/h2/emc/ptmp/karina.asmar/sfs_standalone/post_sfs_1991052100
regression test: /lfs/h2/emc/ptmp/karina.asmar/regression_tests/rt_upp_sfs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarinaAsmar-NOAA This log file shouldn't be committed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WenMeng-NOAA The log file has been deleted.

@KarinaAsmar-NOAA KarinaAsmar-NOAA force-pushed the develop branch 2 times, most recently from e0044b1 to 9d9ea33 Compare February 28, 2024 17:42
@KarinaAsmar-NOAA
Copy link
Contributor Author

The following CPC requested variables have been added to the control files and tested: VVEL (id 20), STRM (id 86), HLCY (162).

Hera standalone test: /scratch1/NCEPDEV/stmp2/Karina.Asmar/sfs_standalone/post_sfs_1991052100 regression test: /scratch1/NCEPDEV/stmp2/Karina.Asmar/regression_tests/rt_upp_sfs

WCOSS2 standalone test: /lfs/h2/emc/ptmp/karina.asmar/sfs_standalone/post_sfs_1991052100 regression test: /lfs/h2/emc/ptmp/karina.asmar/regression_tests/rt_upp_sfs

@WenMeng-NOAA The latest standalone and regression tests with the reverted changes (i.e., removed CPC variables) are in the same paths above.

@WenMeng-NOAA
Copy link
Collaborator

@KarinaAsmar-NOAA Please sync your branch with the latest UPP develop.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. and removed On hold labels Mar 1, 2024
@KarinaAsmar-NOAA
Copy link
Contributor Author

@KarinaAsmar-NOAA Please sync your branch with the latest UPP develop.

@WenMeng-NOAA The branch should be synced now.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There will no baseline changes expected with this PR.

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2 without changed results.

@FernandoAndrade-NOAA
Copy link
Collaborator

Hera and hercules RTs completed without changes to results, Orion is rerunning fv3r due to a fatal error opening PRSLEV within that test case.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There will no baseline changes expected with this PR.

All RTs across Hera, Orion, and Hercules have finished with no changes to results.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 3804b12 into NOAA-EMC:develop Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. SFSV1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precipitation Bucket Setup SFS UPP control files
3 participants