Bug fix for HRRR IFI: Use ifi_apcp if it is 0 #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is expected to change IFI results due to the bugfix in IFI.F It is not expected to change results of other tests. Also, it shouldn't change results of the "ifi missing" tests. |
|
My tests produce a change I don't expect: There are no commits in this PR which should change the result of the rap_2020072316_pe_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bug fix described in detail here:
It corrects a bug in how accumulated hourly precipitation is sent to IFI from within UPP.
I've tested it with the regression tests in this branch:
With these changes, the HRRR UPP IFI and standalone IFI match, which they don't in develop now.