Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CMAQ from 5.2 to 5.4, Use correct variable for LUFRAC_ and DLUSE #106

Open
wants to merge 117 commits into
base: develop
Choose a base branch
from
Open

Upgrade CMAQ from 5.2 to 5.4, Use correct variable for LUFRAC_ and DLUSE #106

wants to merge 117 commits into from

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

PR Checklist

  • This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:

    • RDHPCS.
    • WCOSS2.

  • This PR has been tested with the ufs-srweather-app workflow online-cmaq branch.

  • New or updated input data is required by this PR.

  • Baselines are expected to change.

Description

This PR brings in the CMAQ version 5.4 replacing 5.2.1

Issue(s) addressed

Dependencies

Patrick.C.Campbell@noaa.gov and others added 30 commits February 10, 2022 21:27
Initial commit of rrfs_cmaq_canopy branch.
89e9a4f
Initial copy of canopy photolysis routines.
e38abcd
Initial modifications to canopy photolysis CMAQ5.2.1 codes.
539e975
Updated CMAQ makefiles for modified canopy codes.
941e235
Added new canopy variables to AQM shared components.
f1d72d1
Added placeholder new canopy variables to aqm cap for fv3.
c8a294c
Added conditional CANOPY_SHADE environment variable/logical.
5d73df1
Updated conditional canopy_yn environment and logicals.
4a5f99e
Fixed bugs.
8d6af39
Fixed more bugs.
d906997
Removed "RETURN" bug and added diagnostic prints.
bb85b5e
Removed RETURN bug.
07e3800
Added debug statements
685de08
Removed debug prints and added canopy variables in DESC3.
b00f1c8
Added some debug prints.
846e1dc
Updated debug statemetns
a816991
Fixed bug in declaration.
8c54358
Checking CANOPY_SHADE condition..
830986e
Updated Canopy debugs
cffa402
Fixed CANOPY_SHADE logic bug and added debug prints.
7d49ad1
Removed extraneous debug prints.
c3bc815
Removed debug prints.
2a26402
Fixed allocation/save bug.
2ee012f
@drnimbusrain
Merge pull request #1 from noaa-oar-arl/feature/rrfs_cmaq_canopy
d13f545 
Feature/rrfs cmaq canopy
@drnimbusrain
Update Makefile.in
6cc3005 
Fixed Makefile.in typo.
@drnimbusrain
Update Makefile.in
43c9948
@drnimbusrain
Added new canopy file to read for AQM.
0bef3be
@drnimbusrain
Updated aqm.rc example file.
9b09397
@drnimbusrain
Updated example aqm.rc for canopy settings and file.
3daa4b6
@drnimbusrain
Initial changes for reading canopy data in AQM.
cc0d3e2
btang1 and others added 30 commits August 5, 2023 00:26
@btang1
Add files via upload
c702725 
commented MPAS in CMakeLists.txt
@ytangnoaa
Merge pull request NOAA-EMC#16 from btang1/feature/cmaq54_beiming
37c7dbd 
Add files via upload
@btang1
Add files via upload
6c09037
@btang1
Add files via upload
e2e08b7
@btang1
Add files via upload
a4da052
@btang1
Add files via upload
de38743
@btang1
Update ASX_DATA_MOD.F
584144f
@btang1
Update o3totcol.f
2f507f3
@btang1
Update vdiffacmx.F
d8f049a 
comment a 'end do', after that, code compiled successfully
@btang1
Update aqm_files.cmake
9aa4bff 
turn on according changed codes in local src/ folder
@ytangnoaa
Merge pull request NOAA-EMC#17 from btang1/feature/cmaq54_beiming
8067154 
Add files via upload
@lwcugb
add localized files
18916a2
@lwcugb
Add other modified files
a419a75
@lwcugb
Add other modified files
2306c94
@lwcugb
Update .gitmodules
6351dd4 
point to CMAQ 5.4+
@lwcugb
Update aqm_methods.F90
5e768a6 
Forget to turn on AOD
@drnimbusrain
Merge pull request NOAA-EMC#20 from lwcugb/feature/cmaq54_li
5803ed7 
Feature/cmaq54 li
@lwcugb
Update RUNTIME_VARS.F
4492f16 
Need to comment out two lines for writing to OUTDEV and LOGDEV in aqm_dev branch
@lwcugb
Change aqm_files.cmake to use ROS3 solver
b33ded4
@lwcugb
Add rbdriver.F file to localCCTM folder. There is a typo in CMAQ's so…
ff0892f 
…urce file and therefore need to put it here
@ytangnoaa
Merge pull request NOAA-EMC#23 from lwcugb/feature/camq54_ros3
c30fe95 
Feature/camq54 ros3
@lwcugb
Add files via upload
1de518e 
Better handle of the emission unit. This will not impact the simulation results.
@lwcugb
Update PT3D_STKS_DEFN.F
05a32c1 
Resolve a bug in point source emission. Only the first layer emission is included with his bug, which leads to much lower SO2 simulations.
@lwcugb
Delete some comments for testing purpose
feff981
@ytangnoaa
Merge pull request NOAA-EMC#24 from lwcugb/feature/cmaq54
7bfe2e2 
Fix a bug in point source emission
@ytangnoaa
Update CMakeLists.txt
584637b
@BrianCurtis-NOAA
Bugfixes for debug build try 1
7b147a0
@BrianCurtis-NOAA
Fix issue with array trying to set data where water is
fd35bf0
@BrianCurtis-NOAA
Current testing status updates prior to bringing in FV3 changes
4f65bf6
@BrianCurtis-NOAA
Bring in changes from NOAA-EMC#103
1ab49f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLTYP incorrectly assigned to land use or vtype Updating AQM to CMAQv5.4
8 participants
@BrianCurtis-NOAA @drnimbusrain @bbakernoaa @ytangnoaa @rmontuoro @zmoon @lwcugb @btang1