-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated physics from ufs-dev-pr251 #560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantfirl
approved these changes
Feb 14, 2025
hertneky
approved these changes
Feb 14, 2025
@hertneky @scrasmussen @mkavulich Can one of you update the baselines. There are changes in some of the GF enabled tests. |
One minute, on it! - Soren
…On Fri, Feb 14, 2025 at 3:09 PM Dustin Swales ***@***.***> wrote:
@hertneky <https://github.com/hertneky> @scrasmussen
<https://github.com/scrasmussen> @mkavulich <https://github.com/mkavulich>
Can one of you update the baselines. There are changes in some of the GF
enabled tests.
—
Reply to this email directly, view it on GitHub
<#560 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL364RNOJ3RAUCS3Q2R4HT2PZSQPAVCNFSM6AAAAABXFPY2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQGM3DCMJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: dustinswales]*dustinswales* left a comment (NCAR/ccpp-scm#560)
<#560 (comment)>
@hertneky <https://github.com/hertneky> @scrasmussen
<https://github.com/scrasmussen> @mkavulich <https://github.com/mkavulich>
Can one of you update the baselines. There are changes in some of the GF
enabled tests.
—
Reply to this email directly, view it on GitHub
<#560 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL364RNOJ3RAUCS3Q2R4HT2PZSQPAVCNFSM6AAAAABXFPY2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQGM3DCMJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Soren Rasmussen, Ph.D.
Hydrometeorological Applications Program
Research Applications Laboratory
NSF National Center for Atmospheric Research (NCAR)
|
Done 👍
…On Fri, Feb 14, 2025 at 3:16 PM Soren Rasmussen ***@***.***> wrote:
One minute, on it! - Soren
On Fri, Feb 14, 2025 at 3:09 PM Dustin Swales ***@***.***>
wrote:
> @hertneky <https://github.com/hertneky> @scrasmussen
> <https://github.com/scrasmussen> @mkavulich
> <https://github.com/mkavulich> Can one of you update the baselines.
> There are changes in some of the GF enabled tests.
>
> —
> Reply to this email directly, view it on GitHub
> <#560 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABL364RNOJ3RAUCS3Q2R4HT2PZSQPAVCNFSM6AAAAABXFPY2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQGM3DCMJTGA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
> [image: dustinswales]*dustinswales* left a comment (NCAR/ccpp-scm#560)
> <#560 (comment)>
>
> @hertneky <https://github.com/hertneky> @scrasmussen
> <https://github.com/scrasmussen> @mkavulich
> <https://github.com/mkavulich> Can one of you update the baselines.
> There are changes in some of the GF enabled tests.
>
> —
> Reply to this email directly, view it on GitHub
> <#560 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABL364RNOJ3RAUCS3Q2R4HT2PZSQPAVCNFSM6AAAAABXFPY2GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQGM3DCMJTGA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
Soren Rasmussen, Ph.D.
Hydrometeorological Applications Program
Research Applications Laboratory
NSF National Center for Atmospheric Research (NCAR)
--
Soren Rasmussen, Ph.D.
Hydrometeorological Applications Program
Research Applications Laboratory
NSF National Center for Atmospheric Research (NCAR)
|
All tests pass with identical results. Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.