Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recover option to sdk #8

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

joyqvq
Copy link
Contributor

@joyqvq joyqvq commented Jan 10, 2025

Description

review context: MystenLabs/sui#20722

Test plan

How did you test the new or updated feature?


@joyqvq joyqvq requested a review from hayes-mysten January 10, 2025 20:02
@joyqvq joyqvq requested a review from a team as a code owner January 10, 2025 20:02
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:50pm

@hayes-mysten
Copy link
Contributor

there are some very annoying changes in the latest typescrypt version that make Uint8Array and ArrayBuffer not type-compatible, so it looks like type-checking is failing

@joyqvq joyqvq force-pushed the joy/passkey-recover-feature branch from 3a9aba0 to 08fb5ae Compare January 13, 2025 18:45
@joyqvq joyqvq temporarily deployed to sui-typescript-aws-kms-test-env January 13, 2025 18:45 — with GitHub Actions Inactive
* @param arr2 - The second pubkeys array.
* @returns The only common pubkey in both arrays.
*/
export function findUniquePublicKey(arr1: PublicKey[], arr2: PublicKey[]): PublicKey {
Copy link
Contributor

@hayes-mysten hayes-mysten Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findCommonPublicKey?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also not being exported from the sdk

@joyqvq joyqvq merged commit 1871613 into main Jan 13, 2025
6 checks passed
@joyqvq joyqvq deleted the joy/passkey-recover-feature branch January 13, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants