Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[walrus] add docs #74

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[walrus] add docs #74

wants to merge 6 commits into from

Conversation

hayes-mysten
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


@hayes-mysten hayes-mysten requested a review from a team as a code owner February 20, 2025 22:36
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 1:51am

@@ -1,7 +1,7 @@
{
"name": "@mysten/walrus",
"version": "0.0.0",
"private": true,
"private": false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when we want to do this, we are probably about ready to start publishing the SDK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eek

Copy link
Contributor

@williamrobertson13 williamrobertson13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual docs and comments lgtm, just nitted you a bunch on casings

@@ -1,7 +1,7 @@
{
"name": "@mysten/walrus",
"version": "0.0.0",
"private": true,
"private": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eek

Co-authored-by: William Robertson <williamrobertson13@users.noreply.github.com>
@hayes-mysten hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env February 21, 2025 01:47 — with GitHub Actions Failure
hayes-mysten and others added 2 commits February 20, 2025 17:47
Co-authored-by: William Robertson <williamrobertson13@users.noreply.github.com>
Co-authored-by: William Robertson <williamrobertson13@users.noreply.github.com>
@hayes-mysten hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env February 21, 2025 01:47 — with GitHub Actions Failure
@hayes-mysten hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env February 21, 2025 01:47 — with GitHub Actions Failure
Co-authored-by: William Robertson <williamrobertson13@users.noreply.github.com>
@hayes-mysten hayes-mysten had a problem deploying to sui-typescript-aws-kms-test-env February 21, 2025 01:47 — with GitHub Actions Failure
Co-authored-by: William Robertson <williamrobertson13@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants