create walrus sdk #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hayes-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
hayes-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
hayes-mysten
force-pushed
the
mh--create-walrus-sdk
branch
from
388b8bb to
539168a
Compare
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
hayes-mysten
commented
Jan 10, 2025
| }) { | ||
| const argumentsTypes = [ | ||
| '0000000000000000000000000000000000000000000000000000000000000000::wal_exchange::Exchange', | ||
| '0000000000000000000000000000000000000000000000000000000000000000::wal_exchange::AdminCap', |
There was a problem hiding this comment.
Forgot about this part... I need to update things so that the package address uses the provided address passed into init
hayes-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
williamrobertson13
approved these changes
Jan 10, 2025
packages/walrus/tsconfig.json
Outdated
| "isolatedModules": true, | ||
| "rootDir": "src" | ||
| } | ||
| // "references": [{ "path": "../wallet-standard" }, { "path": "../typescript" }] |
There was a problem hiding this comment.
nit: can we remove this
hayes-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?