DedicatedChannel attribute + connection refactoring #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored connection - Replaced FluentAssertions with Shouldly
- Introduced Toxiproxy - Replaced Moq with NSubstitute - Issue remaining in the unit tests with Management HTTP calls, not sure if it just needs a reboot
- Previous issues was due to not waiting for the RabbitMQ container to start up completely - Reconnect test implemented for client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release branch introduces a DedicatedChannel attribute for high-volume and/or blocking queues. This required some refactoring of the connection handling in TapetiClient. The unit tests have been extended to include a Toxiproxy for connection failure testing, and two basic tests for the reconnection handling.
Pull request created for review purposes.