Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into develop #394

Merged
merged 7 commits into from
Mar 6, 2025
Merged

Merge main into develop #394

merged 7 commits into from
Mar 6, 2025

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Mar 5, 2025

Trying a separate PR to merge main into develop to solve git confusion :(

@hiker
Copy link
Collaborator Author

hiker commented Mar 5, 2025

It should have been a simple merge from main into develop, but git got thoroughly confused and created heaps of duplicated code, trying to resolve imagined conflicts :(
The code changes themselves don't really need to be reviewed (they are from main and have been reviewed), but we need to check that I indeed picked up all duplicated code snippets :(

@hiker hiker requested a review from jasonjunweilyu March 5, 2025 06:15
Copy link
Collaborator

@jasonjunweilyu jasonjunweilyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hiker , one minor typo I think and then this is good to be merged.

@hiker hiker requested a review from jasonjunweilyu March 5, 2025 09:58
Copy link
Collaborator

@jasonjunweilyu jasonjunweilyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hiker, thanks for fixing the typo. I think this is now ready to be merged into develop.

@jasonjunweilyu jasonjunweilyu merged commit d44296c into develop Mar 6, 2025
11 checks passed
@jasonjunweilyu jasonjunweilyu deleted the merge_main_into_develop branch March 6, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants