Code

3 better compiler support#309

Code

Merged

MatthewHambley merged 178 commits intoMetOffice:masterMetOffice/fab:masterfrom hiker:3_better_compiler_supporthiker/fab:3_better_compiler_supportCopy head branch name to clipboardJun 21, 2024

+4,204-1,524

Commits

Commits on Feb 29, 2024

• #278 Use absolute path for source file when compiling Fortran.

  hiker

  committed
  f7ad442

  Copy full SHA for f7ad442

Commits on Mar 1, 2024

• Fixed errors in the psyclone system tests - Issue #4

  

  Junwei Lyu

  committed
  378b47f

  Copy full SHA for 378b47f

Commits on Mar 2, 2024

• Also don't change directory so we can be sure all paths are absolute.

  hiker

  committed
  6b8f73b

  Copy full SHA for 6b8f73b

Commits on Mar 6, 2024

• Minor documentation update for #277.

  hiker

  committed
  071d1a2

  Copy full SHA for 071d1a2

• Remove useless statement, the same value was computed earlier.

  hiker

  committed
  06b0da0

  Copy full SHA for 06b0da0

• Introduced an ArtefactStore objects and getter in build_config.

  hiker

  committed
  ce0890f

  Copy full SHA for ce0890f

• Avoid circular import.

  hiker

  committed
  14a3483

  Copy full SHA for 14a3483

• Updated documentation.

  hiker

  committed
  1e16da4

  Copy full SHA for 1e16da4

Commits on Mar 11, 2024

• #5 Test warnings are either filtered or changed to be alerted when not issued.

  

  Junwei Lyu

  committed
  c7dc9d3

  Copy full SHA for c7dc9d3

• #5, #4: Renamed duplicated filenames in test subdirectories to allow pytest tests at source directory

  

  Junwei Lyu

  committed
  34853c4

  Copy full SHA for 34853c4

Commits on Mar 12, 2024

• Merge pull request #6 from hiker/small_documentation_update

  Show description for d0fb208
  jasonjunweilyu

  authored
  d0fb208

  Copy full SHA for d0fb208

• Merge pull request #7 from hiker/278_absolute_paths_in_compilation

  Show description for 14d0e59
  jasonjunweilyu

  authored
  14d0e59

  Copy full SHA for 14d0e59

• #4: Improved the test error fix to be easier to understand

  

  Junwei Lyu

  committed
  7791733

  Copy full SHA for 7791733

• Merge pull request #9 from hiker/fix_test_error

  Show description for 63d2ddc
  hiker

  authored
  63d2ddc

  Copy full SHA for 63d2ddc

• Removed absolute path patch, since this breaks a test.

  hiker

  committed
  ea7b813

  Copy full SHA for ea7b813

• Fixed failing tests.

  hiker

  committed
  d4b5d8a

  Copy full SHA for d4b5d8a

Commits on Mar 13, 2024

• Resolve merge conflict with branch fix_test_error by incorporating both solutions

  

  Junwei Lyu

  committed
  b8a45c3

  Copy full SHA for b8a45c3

• Fix styling problems reported by Flake8

  

  Junwei Lyu

  committed
  2268191

  Copy full SHA for 2268191

• Fix "_metric_send_conn not set, cannot send metrics" warning not issued, as reported by CI pipeline on Github

  

  Junwei Lyu

  committed
  2cfcb1a

  Copy full SHA for 2cfcb1a

Commits on Mar 14, 2024

• Merge pull request #10 from hiker/fix_test_warning

  Show description for e080c44
  hiker

  authored
  e080c44

  Copy full SHA for e080c44

• Merge branch 'bom_master' into create_artefact_store

  hiker

  committed
  ab9245c

  Copy full SHA for ab9245c

• Remove cosmetic change done to follow other coding standards.

  hiker

  committed
  6b290c2

  Copy full SHA for 6b290c2

• Remove more cosmetic changes (which pylint required).

  hiker

  committed
  71e1b4a

  Copy full SHA for 71e1b4a

• More removal of cosmetic changes, and some useless code.

  hiker

  committed
  ea16694

  Copy full SHA for ea16694

• Add --links option to rsync.

  hiker

  committed
  3160570

  Copy full SHA for 3160570

• Merge branch 'bom_master' into 11_rsync_links

  hiker

  committed
  ed9da03

  Copy full SHA for ed9da03

Commits on Mar 20, 2024

• Merge remote-tracking branch 'upstream/master' into bom_master

  hiker

  committed
  e37b854

  Copy full SHA for e37b854

Commits on Mar 25, 2024

• Merge remote-tracking branch 'upstream/master' into 11_rsync_links

  hiker

  committed
  2da2a4f

  Copy full SHA for 2da2a4f

Commits on Mar 26, 2024

• Merge remote-tracking branch 'upstream/master' into create_artefact_store

  hiker

  committed
  2a209ba

  Copy full SHA for 2a209ba

• Remove unused glob import.

  hiker

  committed
  a8ef7a4

  Copy full SHA for a8ef7a4

• Removed unused glob import.

  hiker

  committed
  ab3ac33

  Copy full SHA for ab3ac33

• Merge branch 'metomi/master' into bom_master after solving conflicts

  

  Junwei Lyu

  committed
  380a210

  Copy full SHA for 380a210

• Fixed typo picked up in review.

  hiker

  committed
  9b9a510

  Copy full SHA for 9b9a510

Commits on Mar 27, 2024

• Merge pull request #8 from hiker/create_artefact_store

  Show description for 0e4e65a
  jasonjunweilyu

  authored
  0e4e65a

  Copy full SHA for 0e4e65a

• Merge pull request #12 from hiker/11_rsync_links

  Show description for 3e27672
  jasonjunweilyu

  authored
  3e27672

  Copy full SHA for 3e27672

• Merge branch 'master' into bom_master

  

  Junwei Lyu

  committed
  12111d4

  Copy full SHA for 12111d4

Commits on Mar 28, 2024

• Merge remote-tracking branch 'upstream/master' into create_artefact_store

  hiker

  committed
  4162c78

  Copy full SHA for 4162c78

• Replaced _artefact_store with getter as much as possible.

  hiker

  committed
  f22bbbf

  Copy full SHA for f22bbbf

• Merge pull request #16 from hiker/create_artefact_store

  Show description for 94a2970
  jasonjunweilyu

  authored
  94a2970

  Copy full SHA for 94a2970

Commits on Apr 15, 2024

• #3 Introduce Tool, Compiler, and ToolRepository.

  hiker

  committed
  119c613

  Copy full SHA for 119c613

• #3 Made ToolRepository a singleton.

  hiker

  committed
  840050e

  Copy full SHA for 840050e

• #3 Added ToolBox.

  hiker

  committed
  5a22091

  Copy full SHA for 5a22091

• #3 Added dedicated enum for categories.

  hiker

  committed
  d288c0e

  Copy full SHA for d288c0e

• #3 Add the category to a tool.

  hiker

  committed
  5fd2cfc

  Copy full SHA for 5fd2cfc

• #3 Use tool category when adding a tool to the tool box.

  hiker

  committed
  a5dd2af

  Copy full SHA for a5dd2af

• #3 Added preprocessor, and dictionary-like accesses to ToolBox.

  hiker

  committed
  b74055b

  Copy full SHA for b74055b

• #3 Added tool_box as mandatory parameter for a BuildConfig.

  hiker

  committed
  126b585

  Copy full SHA for 126b585

Commits on Apr 16, 2024

• #3 Start to use new compiler objects for Fortran compilation.

  hiker

  committed
  0bd9c31

  Copy full SHA for 0bd9c31

• #3 Added tests for Compiler class.

  hiker

  committed
  c13476e

  Copy full SHA for c13476e

• #3 Add specific C- and Fortran-compiler classes. Updated tests.

  hiker

  committed
  c980171

  Copy full SHA for c980171

• #3 Fixed typing.

  hiker

  committed
  1a7300d

  Copy full SHA for 1a7300d

• #3 Moved function to remove into Flags object, added test file for Flags.

  hiker

  committed
  36a6c05

  Copy full SHA for 36a6c05

Commits on Apr 17, 2024

• # Fixed tests to work with new Fortran compiler handling.

  hiker

  committed
  44073c1

  Copy full SHA for 44073c1

• #3 Use for compiler variables if defined.

  hiker

  committed
  2a5bc86

  Copy full SHA for 2a5bc86

• #3 Add is_available flag to tools, added types.

  hiker

  committed
  6f1c18a

  Copy full SHA for 6f1c18a

• #3 Added cpp as Fortran preprocessor.

  hiker

  committed
  5ab1d75

  Copy full SHA for 5ab1d75

• #3 Removed unnecessary code.

  hiker

  committed
  622b748

  Copy full SHA for 622b748

• #3 Properly ignore mypy warnings.

  hiker

  committed
  f2f73cd

  Copy full SHA for f2f73cd

• Support ToolBox for preprocessing.

  hiker

  committed
  09e93a2

  Copy full SHA for 09e93a2

• #3 Add a specific 'preprocess' method to Preprocessor.

  hiker

  committed
  51b02ec

  Copy full SHA for 51b02ec

Commits on Apr 19, 2024

• #3 Changed order in which compiler flags are used.

  hiker

  committed
  f917c07

  Copy full SHA for f917c07

• #3 Use toolbox in compile_c step.

  hiker

  committed
  1d154d7

  Copy full SHA for 1d154d7

• #3 Added get_hash function to compiler.

  hiker

  committed
  302d58b

  Copy full SHA for 302d58b

Commits on Apr 22, 2024

• #3 Added conftest.py file (with a fixture to create a C-compiler).

  hiker

  committed
  4068505

  Copy full SHA for 4068505

• #3 Introduce fixtures for Fortran compiler and tool_box.

  hiker

  committed
  f24d939

  Copy full SHA for f24d939

• #3 Remove explicit compiler information from MpCommonArgs (since it's already part of the config toolbox).

  hiker

  committed
  075ed40

  Copy full SHA for 075ed40

• Merge branch 'master' into bom_master

  hiker

  committed
  15fca77

  Copy full SHA for 15fca77

• Merge branch 'bom_master' of github.com:hiker/fab into bom_master

  hiker

  committed
  d862762

  Copy full SHA for d862762

• Merge branch 'master' into 3_better_compiler_support

  hiker

  committed
  e999cd1

  Copy full SHA for e999cd1

Commits on Apr 23, 2024

• #3 Added linker as tool.

  hiker

  committed
  fdc402c

  Copy full SHA for fdc402c

• #3 Added test for linking shared libraries.

  hiker

  committed
  b50b3df

  Copy full SHA for b50b3df

• #3 Pass compiler flags to the linker if a compiler was specified.

  hiker

  committed
  b3806f1

  Copy full SHA for b3806f1

• #3 Remove unused function.

  hiker

  committed
  2cf63d3

  Copy full SHA for 2cf63d3

• #3 Removed more unused code.

  hiker

  committed
  2fffe56

  Copy full SHA for 2fffe56

Commits on Apr 24, 2024

• #3 Automatically add a linker for each compiler.

  hiker

  committed
  7a8c293

  Copy full SHA for 7a8c293

• #3 Fixed typo.

  hiker

  committed
  555de52

  Copy full SHA for 555de52

• #3 Support vendor for compiler and linker.

  hiker

  committed
  abec46d

  Copy full SHA for abec46d

• #3 Make linker having a vendor, too.

  hiker

  committed
  d4ad3f0

  Copy full SHA for d4ad3f0

• #3 Add set_default_vendor method to tool repository.

  hiker

  committed
  a64c9b7

  Copy full SHA for a64c9b7

Commits on Apr 29, 2024

• Ignore build directory for git.

  hiker

  committed
  8a8781d

  Copy full SHA for 8a8781d

• Merge remote-tracking branch 'upstream/master' into 3_better_compiler_support

  hiker

  committed
  4c2f0d8

  Copy full SHA for 4c2f0d8

• Merge remote-tracking branch 'upstream/master' into bom_master

  hiker

  committed
  ccbe839

  Copy full SHA for ccbe839

• # Fix some mypy errors and warnings.

  hiker

  committed
  227a153

  Copy full SHA for 227a153

Commits on Apr 30, 2024

• Avoid using get() for singleton, instead use __new__ which makes mypy happier.

  hiker

  committed
  b8c64b9

  Copy full SHA for b8c64b9

• Changed the transformation_script parameter of function psyclone to accept a function that can return file-specific transformation scripts

  

  Junwei Lyu

  committed
  e309c15

  Copy full SHA for e309c15

• Make mypy happy by using patch.object.

  hiker

  committed
  31a4877

  Copy full SHA for 31a4877

• Remove more comments and confusion about mypy :)

  hiker

  committed
  fbb15ea

  Copy full SHA for fbb15ea

• Try to make mypy happy on older python versions.

  hiker

  committed
  7f52d40

  Copy full SHA for 7f52d40

• Make flake8 happy.

  hiker

  committed
  ca58d67

  Copy full SHA for ca58d67

• Sort imported name alphabetically.

  hiker

  committed
  c218bcd

  Copy full SHA for c218bcd

• Try to fix failing hash test (and add some additional improvements in the test).

  hiker

  committed
  e14d5b3

  Copy full SHA for e14d5b3

• Removed fpath= for input transformation_script function to pass mypy test for Python 3.7; Moved transformation_script_hash test to unit test from system test

  

  Junwei Lyu

  committed
  0986b43

  Copy full SHA for 0986b43

• Fix mypy typing check errors for psyclone unit test

  

  Junwei Lyu

  committed
  2e15f19

  Copy full SHA for 2e15f19

• Fix config typing issue with mypy in psyclone unit test

  

  Junwei Lyu

  committed
  1eeaa35

  Copy full SHA for 1eeaa35

• Fix flake8 issues; Revert Config mypy typing fix

  

  Junwei Lyu

  committed
  a45d62b

  Copy full SHA for a45d62b

• Add comment to ignore typing check for fpath parameter of input transformation_script function

  

  Junwei Lyu

  committed
  a4a9aab

  Copy full SHA for a4a9aab

• Fix assert check after transformation_script function is changed from being called twice to once

  

  Junwei Lyu

  committed
  5978e80

  Copy full SHA for 5978e80

• Filter out 'no transformation script' warning for psyclone system test

  

  Junwei Lyu

  committed
  e70885d

  Copy full SHA for e70885d

• Replace 'ignore' typing of fpath of transformation_script with removing keyword argument

  

  Junwei Lyu

  committed
  d2c6db0

  Copy full SHA for d2c6db0

• #3 Support proper tests to check if tools are available.

  hiker

  committed
  a2ac207

  Copy full SHA for a2ac207

Commits on May 3, 2024

• 1. Updated transformation_script description; 2. Modified mock_transformation_script; 3.Removed redundant _analysis_for_prebuilds

  

  Junwei Lyu

  committed
  3a5e86a

  Copy full SHA for 3a5e86a

• Updated lfric/atm.py and lfric/gungho.py examples to pass in transformation_script functions

  

  Junwei Lyu

  committed
  4ab3737

  Copy full SHA for 4ab3737

• Added description for the psyclone step to instructions on writing a config

  

  Junwei Lyu

  committed
  92545f8

  Copy full SHA for 92545f8

Commits on May 6, 2024

• #3 Added git as a tool.

  hiker

  committed
  f7cbf39

  Copy full SHA for f7cbf39

• #3 Fix incorrect | usage in typing.

  hiker

  committed
  632fa8c

  Copy full SHA for 632fa8c

Commits on May 7, 2024

• #3 Added unit tests for git.

  hiker

  committed
  e0261c7

  Copy full SHA for e0261c7

• #3 Renamed git.py to versioning.py, to avoid name clash with the corresponding test_git.py tests.

  hiker

  committed
  f6357a1

  Copy full SHA for f6357a1

Commits on May 8, 2024

• #3 Converted svn and fcm to tools.

  hiker

  committed
  042e8d8

  Copy full SHA for 042e8d8

• #3 Fixed missing whitespace.

  hiker

  committed
  87bce71

  Copy full SHA for 87bce71

Commits on May 9, 2024

• Modified the documentation for writing a config with PSyclone

  

  Junwei Lyu

  committed
  14e4f7c

  Copy full SHA for 14e4f7c

Commits on May 10, 2024

• Add config as a parameter for run_psyclone for the transformation_script to use;Updated the related functions and tests;

  Show description for d38f020
  

  Junwei Lyu

  committed
  d38f020

  Copy full SHA for d38f020

• #3 Replaced ar with tool object.

  hiker

  committed
  672bb9c

  Copy full SHA for 672bb9c

Commits on May 13, 2024

• #3 Added tests for ar.py.

  hiker

  committed
  8987f99

  Copy full SHA for 8987f99

• #3 Removed debug output.

  hiker

  committed
  eee5043

  Copy full SHA for eee5043

• #3 Converted PSyclone to be a tool.

  hiker

  committed
  f9fdbbb

  Copy full SHA for f9fdbbb

• #3 Removed debug print, fixed python 3.7 typing information.

  hiker

  committed
  be36931

  Copy full SHA for be36931

• #3 Updated comments.

  hiker

  committed
  8c790ce

  Copy full SHA for 8c790ce

• Modified the get_optimisation_script function examples and updated the doc formatting

  

  Junwei Lyu

  committed
  ade5f67

  Copy full SHA for ade5f67

• #3 Add Rsync tool.

  hiker

  committed
  15212ae

  Copy full SHA for 15212ae

• #3 Removed now unused function.

  hiker

  committed
  48c7543

  Copy full SHA for 48c7543

• #3 Added test for rsync.

  hiker

  committed
  664c89c

  Copy full SHA for 664c89c

• #3 Fixed all mypy warnings about functions not checked.

  hiker

  committed
  44756f7

  Copy full SHA for 44756f7

• #3 Replace all mock-tests to use subprocess so the name of the executable is tested as well.

  hiker

  committed
  064ea35

  Copy full SHA for 064ea35

• #3 Remove duplicated flags.

  hiker

  committed
  22a1b91

  Copy full SHA for 22a1b91

• #3 Fixed changed order of linking.

  hiker

  committed
  2e1b0a1

  Copy full SHA for 2e1b0a1

• #3 Removed run_command function.

  hiker

  committed
  921daa8

  Copy full SHA for 921daa8

• #3 Fixed 3.8 typing error.

  hiker

  committed
  fc668cd

  Copy full SHA for fc668cd

• #3 Fixed unused imports.

  hiker

  committed
  47a0a70

  Copy full SHA for 47a0a70

Commits on May 14, 2024

• #3 Move flags checksum into Flags, and remove now unused tools.py file.

  hiker

  committed
  4389374

  Copy full SHA for 4389374

• #3 Renamed newtools to tools.

  hiker

  committed
  3a015d2

  Copy full SHA for 3a015d2

• #3 Made custom function for all git functions called (instead of just calling run).

  hiker

  committed
  202e274

  Copy full SHA for 202e274

• #3 Updated and fixed comments.

  hiker

  committed
  3667030

  Copy full SHA for 3667030

• #3 Fixed errors in comments.

  hiker

  committed
  860d5a3

  Copy full SHA for 860d5a3

Commits on May 15, 2024

• Fixed minor errors in documentation.

  hiker

  committed
  25a1f58

  Copy full SHA for 25a1f58

• Merge pull request #19 from hiker/18_optimisation_script

  Show description for 2562c22
  hiker

  authored
  2562c22

  Copy full SHA for 2562c22

• #3 Make it easier to create wrapper around standard compiler.

  hiker

  committed
  72f7ab5

  Copy full SHA for 72f7ab5

• #3 Added documentation for all tool related classes and their usage.

  hiker

  committed
  53aeb62

  Copy full SHA for 53aeb62

Commits on May 21, 2024

• #3 Added MISC category.

  hiker

  committed
  8723a4e

  Copy full SHA for 8723a4e

Commits on May 29, 2024

• Addressed reviewer's comments.

  hiker

  committed
  358ae23

  Copy full SHA for 358ae23

• Updated cli to properly use ToolBox etc, removing hard-coded gnu command linker option.

  hiker

  committed
  71e0b2f

  Copy full SHA for 71e0b2f

• Merge remote-tracking branch 'origin/bom_master' into 3_better_compiler_support

  hiker

  committed
  b33b8b5

  Copy full SHA for b33b8b5

• Fixed mypy failures, including changes to import statement to avoid cyclic imports :(.

  hiker

  committed
  1109a88

  Copy full SHA for 1109a88

Commits on May 30, 2024

• #3 Fix circular import.

  hiker

  committed
  8e303f5

  Copy full SHA for 8e303f5

Commits on Jun 6, 2024

• Try to fix all run_configs.

  hiker

  committed
  ac93579

  Copy full SHA for ac93579

• Fixed rebase issues.

  hiker

  committed
  2f633b9

  Copy full SHA for 2f633b9

Commits on Jun 7, 2024

• Removed linker argument from linking step in all examples.

  hiker

  committed
  7570696

  Copy full SHA for 7570696

• Try to get jules to link.

  hiker

  committed
  41d9273

  Copy full SHA for 41d9273

• Fixed build_jules.

  hiker

  committed
  56f001a

  Copy full SHA for 56f001a

• Fixed other issues raised in reviews.

  hiker

  committed
  8fb2be1

  Copy full SHA for 8fb2be1

Commits on Jun 11, 2024

• Merge branch 'master' into 3_better_compiler_support

  hiker

  committed
  169ff69

  Copy full SHA for 169ff69

Commits on Jun 17, 2024

• Removed setter for tool.is_available, which was only used for testing.

  hiker

  committed
  f0e660d

  Copy full SHA for f0e660d

• #3 Fix documentation and coding style issues from review.

  hiker

  committed
  9f1ffc3

  Copy full SHA for 9f1ffc3

• Renamed Categories into Category.

  hiker

  committed
  a0531a2

  Copy full SHA for a0531a2

• Minor coding style cleanup.

  hiker

  committed
  4ff887c

  Copy full SHA for 4ff887c

• Removed more unnecessary ().

  hiker

  committed
  8a3b02d

  Copy full SHA for 8a3b02d

• Re-added (invalid) grab_pre_build call.

  hiker

  committed
  10ae159

  Copy full SHA for 10ae159

• Fixed typo.

  hiker

  committed
  622d0bd

  Copy full SHA for 622d0bd

Commits on Jun 18, 2024

• Renamed set_default_vendor to set_default_compiler_suite.

  hiker

  committed
  3f48703

  Copy full SHA for 3f48703

• Renamed VendorTool to CompilerSuiteTool.

  hiker

  committed
  ba9245d

  Copy full SHA for ba9245d

• Also accept a Path as exec_name specification for a tool.

  hiker

  committed
  f8c4418

  Copy full SHA for f8c4418

• Move the check_available function into the base class.

  hiker

  committed
  6a7aef8

  Copy full SHA for 6a7aef8

• Fixed some types and documentation.

  hiker

  committed
  0b73089

  Copy full SHA for 0b73089

• Fix typing error.

  hiker

  committed
  7796246

  Copy full SHA for 7796246

• Added explanation for meta-compiler.

  hiker

  committed
  412a136

  Copy full SHA for 412a136

• Improved error handling and documentation.

  hiker

  committed
  8ec2227

  Copy full SHA for 8ec2227

• Replace mpiifort with mpifort to be a tiny bit more portable.

  hiker

  committed
  6d1a1ee

  Copy full SHA for 6d1a1ee

• Use classes to group tests for git/svn/fcm together.

  hiker

  committed
  8d4c66f

  Copy full SHA for 8d4c66f

• Merge remote-tracking branch 'upstream/master' into 3_better_compiler_support

  hiker

  committed
  ffdfd1a

  Copy full SHA for ffdfd1a

Commits on Jun 20, 2024

• Added reference to ticket.

  hiker

  committed
  516ec34

  Copy full SHA for 516ec34

• Updated type information.

  hiker

  committed
  ee2fc85

  Copy full SHA for ee2fc85

• More typing fixes.

  hiker

  committed
  5912e59

  Copy full SHA for 5912e59

Commits on Jun 21, 2024

• Fixed typing warnings.

  hiker

  committed
  83ba6a1

  Copy full SHA for 83ba6a1

• As requested by reviewer removed is_working_copy functionality.

  hiker

  committed
  7e66eca

  Copy full SHA for 7e66eca

• Issue a warning (which can be silenced) when a tool in a toolbox is replaced.

  hiker

  committed
  ddd3cf2

  Copy full SHA for ddd3cf2

• Fixed flake8.

  hiker

  committed
  68bc218

  Copy full SHA for 68bc218

• Merge remote-tracking branch 'upstream/master' into 3_better_compiler_support

  hiker

  committed
  2bdcb8c

  Copy full SHA for 2bdcb8c

• Fixed flake8.

  hiker

  committed
  c02729c

  Copy full SHA for c02729c

• Merge remote-tracking branch 'upstream/master' into 3_better_compiler_support

  hiker

  committed
  a29be95

  Copy full SHA for a29be95