Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brakeman warnings #23356

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Mar 3, 2025

Remove the Rails 7.0 and CSRF warnings now that we are on Rails 7.1.
Update the Ruby 3.1 warning with the new fingerprint.

Remove the Rails 7.0 and CSRF warnings now that we are on Rails 7.1.
Update the Ruby 3.1 warning with the new fingerprint.
@Fryguy Fryguy force-pushed the fix_brakeman_warnings branch from c924884 to 49e8499 Compare March 3, 2025 22:38
Comment on lines -35 to +16
"confidence": "Weak",
"confidence": "Medium",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what caused the fingerprint to change.

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on 💚

@Fryguy
Copy link
Member Author

Fryguy commented Mar 3, 2025

security is 💚 🎉

@jrafanie
Copy link
Member

jrafanie commented Mar 3, 2025

Merging to get master green. Security is green as this is what was failing previously.

@jrafanie jrafanie merged commit 9798604 into ManageIQ:master Mar 3, 2025
8 checks passed
@Fryguy Fryguy deleted the fix_brakeman_warnings branch March 3, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants