Add a block option to checkout_git_repository #23235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Fryguy
reviewed
Oct 16, 2024
app/models/manageiq/providers/embedded_automation_manager/configuration_script_source.rb
Outdated
Show resolved
Hide resolved
agrare
force-pushed
the
configuration_script_source_git_repo_checkout
branch
from
1ecf92f to
3f979d4
Compare
Fryguy
approved these changes
Oct 16, 2024
|
@agrare Would it be possible to add specs for this? |
|
Yeah let me take a look at it |
agrare
force-pushed
the
configuration_script_source_git_repo_checkout
branch
2 times, most recently
from
4c8c159 to
a28c407
Compare
agrare
force-pushed
the
configuration_script_source_git_repo_checkout
branch
from
a28c407 to
f243d3a
Compare
|
Checked commit agrare@f243d3a with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is up to the caller to create the temporary directory, pass that to checkout_git_repository, and clean that directory up.
If a caller doesn't need to keep the directory around across method invocations they could pass a block in and let the checkout_git_repository method clean up the temp directory.
Ref: ManageIQ/manageiq-providers-embedded_terraform#75 (comment)
Follow-ups: