Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old provider haml files #9017

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Jan 11, 2024

Remove old provider haml files. Also removed dependent haml files and their related spec files as they are now no longer needed.

These are the new React forms for these pages. By deleting the haml forms we can also delete the haml files that these forms depend on.
Screenshot 2024-01-15 at 10 10 14 AM
Screenshot 2024-01-15 at 10 11 49 AM
Screenshot 2024-01-15 at 10 12 12 AM

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner January 11, 2024 16:20
@GilbertCherrie GilbertCherrie force-pushed the remove_old_ems_haml_forms branch 5 times, most recently from b29cd52 to fcff4e3 Compare January 11, 2024 18:24
@GilbertCherrie GilbertCherrie force-pushed the remove_old_ems_haml_forms branch from fcff4e3 to 820e44c Compare January 11, 2024 18:24
@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2024

Checked commit GilbertCherrie@820e44c with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@jeffibm jeffibm merged commit 6cd43b3 into ManageIQ:master Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants