-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opentofu-runner service #450
Conversation
c1b5702
to
5195277
Compare
Can you add this type of thing to the pluggability checklist as well? |
I can add it but I'm not sure how pluggable the RPM build is or can be, not aware of any other aspect of it that we have overridden in plugins @bdunne ? |
5195277
to
bfed0c2
Compare
We have systemd units pluggable but it's pluggable generically by name (i.e. manageiq-providers-*) on the rpm side... Not sure how we can do it any differently |
Right the opentofu-runner.service content is already defined in the provider repo, one thing that comes to mind is if we don't care about splitting up "core-services" and "gemset-services" we could just take |
Yeah I'm not sure why we have them split other than the rpms themselves are split that way |
bfed0c2
to
c3b59a9
Compare
Checked commit agrare@c3b59a9 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
I'm going to merge this on red. The failures are the new openssl issue, and @agrare has built this multiple times without failure, so I think it's good. |
Depends on: