Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentofu-runner service #450

Merged
merged 1 commit into from
May 2, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 14, 2024

@agrare agrare force-pushed the add_opentofu_runner_service branch 2 times, most recently from c1b5702 to 5195277 Compare March 14, 2024 18:51
@Fryguy
Copy link
Member

Fryguy commented Mar 14, 2024

Can you add this type of thing to the pluggability checklist as well?

@agrare
Copy link
Member Author

agrare commented Mar 14, 2024

I can add it but I'm not sure how pluggable the RPM build is or can be, not aware of any other aspect of it that we have overridden in plugins @bdunne ?

@Fryguy Fryguy added the enhancement New feature or request label Mar 27, 2024
@Fryguy Fryguy self-assigned this Mar 27, 2024
@agrare agrare force-pushed the add_opentofu_runner_service branch from 5195277 to bfed0c2 Compare April 4, 2024 14:56
@Fryguy
Copy link
Member

Fryguy commented Apr 4, 2024

We have systemd units pluggable but it's pluggable generically by name (i.e. manageiq-providers-*) on the rpm side... Not sure how we can do it any differently

@agrare
Copy link
Member Author

agrare commented Apr 4, 2024

Right the opentofu-runner.service content is already defined in the provider repo, one thing that comes to mind is if we don't care about splitting up "core-services" and "gemset-services" we could just take %{_prefix}/lib/systemd/system/*.{service,target}

@Fryguy
Copy link
Member

Fryguy commented Apr 4, 2024

Yeah I'm not sure why we have them split other than the rpms themselves are split that way

@agrare agrare force-pushed the add_opentofu_runner_service branch from bfed0c2 to c3b59a9 Compare May 2, 2024 17:20
@miq-bot
Copy link
Member

miq-bot commented May 2, 2024

Checked commit agrare@c3b59a9 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy
Copy link
Member

Fryguy commented May 2, 2024

I'm going to merge this on red. The failures are the new openssl issue, and @agrare has built this multiple times without failure, so I think it's good.

@Fryguy Fryguy merged commit e77a7f5 into ManageIQ:master May 2, 2024
2 of 3 checks passed
@agrare agrare deleted the add_opentofu_runner_service branch May 3, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants