Rails 7 mvp (just get it runnable with rails 7)

[jrafanie]

These were extracted from #133

• Allow rails 7 in gemspec
• Use new location for grouped_records in rails 7, add our patches to it
• Remove rails 6.0 and lower code

Additionally, I added warnings if the expected class is missing instance methods for the different versions of rails. That way, if we try to prepend methods in future versions, we'll know if they were renamed or removed.

💚 Cross repo

[jrafanie]

Wording is hard. Here's what it looks like when I run the tests with a bogus xxx method added to the list of methods we expect to be there:

NameError:
  ActiveRecord::Associations::Preloader is missing the method our prepended code is expecting to patch. Was the undefined method removed or renamed upstream?
  See: /Users/joerafaniello/Code/activerecord-virtual_attributes/lib/active_record/virtual_attributes/virtual_fields.rb.
  The NameError was: undefined method `xxx' for class `ActiveRecord::Associations::Preloader'

      klass.instance_method(instance_method)
           ^^^^^^^^^^^^^^^^.

      raise NameError, msg
      ^^^^^

[jrafanie]

We will have to bump the minor version for this anyway with adding rails 7 support but since we're already dropping 6.0 and older, we can include this and just bump the major version.

[kbrock]

remember, this is not semver, we need to follow versions that signify this is good for rails 7.0.x - so we'll be using 7.0.y (y is not x, x is theirs, y is ours)

[jrafanie]

@miq-bot cross-repo-tests /all

[jrafanie]

Cross repo is green for this on rails 6.1. I'm continuing to look at rails 7 failures in cross repo plus this branch but they may be unrelated to this branch. Getting this merged into master will help. We can release a tag when I confirm there are no other rails 7 fixes needed.

[jrafanie]

@kbrock this is ready for review/merge. Thanks!

[jrafanie]

I fixed most of the cops, leaving the remaining as that is how it was coming from rails with our minor changes.

[miq-bot]

Checked commits jrafanie/activerecord-virtual_attributes@9885686~...f8b0bc7 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 3 offenses detected

lib/active_record/virtual_attributes/virtual_fields.rb

• ⚠️ - Line 223, Col 25 - Lint/AmbiguousOperatorPrecedence - Wrap expressions with varying precedence with parentheses to avoid ambiguity.
• ❗ - Line 208, Col 7 - Style/MultilineIfModifier - Favor a normal if-statement over a modifier clause in a multiline statement.
• ❗ - Line 209, Col 28 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.

[jrafanie]

Ok, I've addressed the comments, most of the cops and cross repo is green on Rails 6.1.

[jrafanie]

@Fryguy this is ready for review/merge

[jrafanie]

This is ready for review/merge. Thanks!

[jrafanie]

@kbrock what are your thoughts on merging/releasing this one?

[kbrock]

I admit I'm a little hesitant on deleting the calculate.
Hard to remember the exact issue why e needed to add that clause.

But LGTM

UPDATE: those virtual total tests are very pedantic. Feeling much more comfortable after reading through those again. Feels like it would be very tricky for anything to sneak by