Merge pull request #160 from MITLibraries/gdt-271-publishers-in-more-…

…info Add publishers to geospatial full records
MITLibraries · Apr 5, 2024 · c2e2923 · c2e2923
2 parents 9cb4da5 + a10100a
commit c2e2923
Show file tree

Hide file tree

Showing 14 changed files with 196 additions and 102 deletions.
diff --git a/app/helpers/record_helper.rb b/app/helpers/record_helper.rb
@@ -103,7 +103,7 @@ def access_type(metadata)
   # Note: the publishers field is not yet available in TIMDEX API, but it should be added here once it is.
   def more_info_geo?(metadata)
     relevant_fields = %w[alternate_titles contributors dates format identifiers languages locations
-                         links notes provider rights]
+                         links notes provider publishers rights]
     metadata.keys.any? { |key| relevant_fields.include? key }
   end
 

diff --git a/app/models/timdex_record.rb b/app/models/timdex_record.rb
@@ -72,7 +72,11 @@ class TimdexRecord < TimdexBase
         physicalDescription
         provider
         publicationFrequency
-        publicationInformation
+        publishers {
+          date
+          location
+          name
+        }
         relatedItems {
           description
           itemType

diff --git a/app/views/record/_more_info_geo.html.erb b/app/views/record/_more_info_geo.html.erb
@@ -94,4 +94,14 @@
       </ul>
     </li>
   <% end %>
+
+  <% if metadata['publishers'].present? %>
+    <li><strong>Publishers</strong>
+      <ul>
+      <% parse_nested_field(metadata['publishers']).each do |subfield| %>
+        <li><%= render_subfield(subfield) %></li>
+      <% end %>
+      </ul>
+    </li>
+  <% end %>
 </ul>
diff --git a/config/schema/schema.json b/config/schema/schema.json
@@ -1213,6 +1213,61 @@
           "enumValues": null,
           "possibleTypes": null
         },
+        {
+          "kind": "OBJECT",
+          "name": "Publishers",
+          "description": null,
+          "fields": [
+            {
+              "name": "date",
+              "description": "The date of the publication",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "SCALAR",
+                "name": "String",
+                "ofType": null
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "location",
+              "description": "Where the publisher is located",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "SCALAR",
+                "name": "String",
+                "ofType": null
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "name",
+              "description": "The name of the publisher",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "SCALAR",
+                "name": "String",
+                "ofType": null
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            }
+          ],
+          "inputFields": null,
+          "interfaces": [
+
+          ],
+          "enumValues": null,
+          "possibleTypes": null
+        },
         {
           "kind": "OBJECT",
           "name": "Query",
@@ -1943,7 +1998,7 @@
                 }
               },
               "isDeprecated": true,
-              "deprecationReason": "Use `publicationInformation`"
+              "deprecationReason": "Use `publishers`"
             },
             {
               "name": "inBibliography",
@@ -2243,7 +2298,7 @@
             },
             {
               "name": "publicationInformation",
-              "description": "Imprint information for item",
+              "description": null,
               "args": [
 
               ],
@@ -2260,6 +2315,28 @@
                   }
                 }
               },
+              "isDeprecated": true,
+              "deprecationReason": "Use `publishers`"
+            },
+            {
+              "name": "publishers",
+              "description": "Publishers that are associated with the item",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "LIST",
+                "name": null,
+                "ofType": {
+                  "kind": "NON_NULL",
+                  "name": null,
+                  "ofType": {
+                    "kind": "OBJECT",
+                    "name": "Publishers",
+                    "ofType": null
+                  }
+                }
+              },
               "isDeprecated": false,
               "deprecationReason": null
             },

diff --git a/test/helpers/record_helper_test.rb b/test/helpers/record_helper_test.rb
@@ -279,6 +279,10 @@ class RecordHelperTest < ActionView::TestCase
 
     provider_record = { 'provider' => 'MIT' }
     assert more_info_geo?(provider_record)
+
+    publishers_record = { 'publishers' => [{ 'name' => 'Jagjaguwar', 'location' => 'Bloomington, IN',
+                                             'date' => '2011' }] }
+    assert more_info_geo?(provider_record)
   end
 
   test 'more_info_geo? false if no more info available' do

diff --git a/test/vcr_cassettes/alma_record_with_no_publication_date.yml b/test/vcr_cassettes/alma_record_with_no_publication_date.yml