Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds search engine directives to results pages #1426

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Adds search engine directives to results pages #1426

merged 1 commit into from
Feb 28, 2025

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Feb 28, 2025

  • Adds google developer console ownership file
  • Adds noindex, nofollow headers on all results pages

https://mitlibraries.atlassian.net/browse/PW-146

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

@mitlib mitlib temporarily deployed to mit-bento-pr-1426 February 28, 2025 13:31 Inactive
* Adds google developer console ownership file
* Adds noindex, nofollow headers on all results pages

https://mitlibraries.atlassian.net/browse/PW-146
@JPrevost JPrevost temporarily deployed to mit-bento-pr-1426 February 28, 2025 14:25 Inactive
@coveralls
Copy link

coveralls commented Feb 28, 2025

Coverage Status

coverage: 99.07%. remained the same
when pulling 18367ee on gsc
into 4622395 on main.

@jazairi jazairi self-assigned this Feb 28, 2025
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, and yes, non-controversial. 🙂

@JPrevost JPrevost merged commit abcbd89 into main Feb 28, 2025
4 checks passed
@JPrevost JPrevost deleted the gsc branch February 28, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants