Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rails 2.29.1 → 2.30.2 (minor) #1423

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Feb 25, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.29.1 → 2.30.2) · Repo · Changelog

Release Notes

2.30.2

Bug fixes

  • #1447: Fix false positive for Rails/LexicallyScopedActionFilter when action methods are delegated. (@vlad-pisanov)
  • #1446: Fix false positives for Rails/Delegate when module_function is used. (@ydakuka)
  • #1427: Fix an error for Rails/UniqBeforePluck when pluck and unique are on different lines. (@earlopain)

2.30.1

Bug fixes

  • #1442: Fix an incorrect behavior when using AllCops: TargetRailsVersion. (@koic)
  • #1444: Fix an incorrect behavior when using AllCops: MigratedSchemaVersion. (@koic)

2.30.0

New features

Bug fixes

  • #1071: Fix Rails/FilePath cop to correctly handle File.join with variables and ignore leading and multiple slashes in string literal arguments for Rails.root.join and File.join. (@ydakuka)
  • #912: Enhance Rails/Delegate by adding delegation detection for self.class, constants, class variables, global variables, and instance variables. (@ydakuka)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 41 commits:

✳️ rubocop (1.71.2 → 1.72.2) · Repo · Changelog

Release Notes

1.72.2

Bug fixes

  • #13853: Fix exclusion of relative paths in plugin's AllCops: Exclude as expected. (@koic)
  • #13844: Fix an error for Style/RedundantFormat when a template argument is used without keyword arguments. (@koic)
  • #13857: Fix an error for Style/RedundantFormat when numeric placeholders is used in the template argument. (@koic)
  • #13861: Fix ArgumentError related to two deprecated AllowedPattern APIs. (@koic)
  • #13849: Fix an error for Lint/UselessConstantScoping when multiple assigning to constants after private access modifier. (@koic)
  • #13856: Fix false positives for Lint/UselessConstantScoping when a constant is used after private access modifier with arguments. (@koic)

Changes

  • #13846: Mark Style/RedundantFormat as unsafe autocorrect. (@koic)

1.72.1

Bug fixes

  • #13836: Fix an error for Style/RedundantParentheses when a different expression appears before a range literal. (@koic)
  • #13839: Fix false positives for Lint/RedundantTypeConversion when passing block arguments when generating a Hash or a Set. (@koic)

Changes

  • #13839: Extension plugin is loaded automatically with require 'rubocop/rspec/support'. (@koic)

1.72.0

New features

  • #13740: Add new Lint/CopDirectiveSyntax cop. (@kyanagi)
  • #13800: Add new Lint/SuppressedExceptionInNumberConversion cop. (@koic)
  • #13702: Add new Lint/RedundantTypeConversion cop. (@dvandersluis)
  • #13831: Add new Lint/UselessConstantScoping cop. (@koic)
  • #13793: Add new Style/RedundantFormat cop to check for uses of format or sprintf with only a single string argument. (@dvandersluis)
  • #13581: Add new InternalAffairs/LocationExists cop to check for code that can be replaced with Node#loc? or Node#loc_is?. (@dvandersluis)
  • #13661: Make server mode detect local paths in .rubocop.yml under inherit_from and require for automatically restart. (@koic)
  • #13721: Naming/PredicateName: Optionally use Sorbet to detect predicate methods. (@issyl0)
  • #6012: Support RuboCop extension plugin. (@koic)

Bug fixes

  • #13807: Fix false negatives for Style/RedundantParentheses when chaining [] method calls. (@koic)
  • #13788: Fix false negatives for Style/RedundantParentheses when [] method is called with variable or constant receivers. (@koic)
  • #13811: Fix false negatives for Style/RedundantParentheses when handling range literals with redundant parentheses. (@koic)
  • #13796: Fix crash in Layout/EmptyLinesAroundMethodBody for endless methods. (@dvandersluis)
  • #13817: Fix false positive for format specifier with non-numeric precision. (@dvandersluis)
  • #12672: Fix false positives for Lint/FormatParameterMismatch when the width value is interpolated. (@dvandersluis)
  • #12795: Fix Layout/BlockAlignment for blocks that are the body of an endless method. (@dvandersluis)
  • #13822: Fix undefined method Logger when processing watched file notifications. (@vinistock)
  • #13805: Make the language_server-protocol dependency version stricter. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 72 commits:

↗️ json (indirect, 2.10.0 → 2.10.1) · Repo · Changelog

Release Notes

2.10.1 (from changelog)

  • Fix a compatibility issue with MultiJson.dump(obj, pretty: true): no implicit conversion of false into Proc (TypeError).

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 4 commits:

↗️ logger (indirect, 1.6.5 → 1.6.6) · Repo

Sorry, we couldn't find anything useful about this release.

↗️ rack (indirect, 3.1.9 → 3.1.10) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

🆕 lint_roller (added, 1.1.0)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Feb 25, 2025
@mitlib mitlib temporarily deployed to mit-bento-pr-1423 February 25, 2025 09:17 Inactive
@coveralls
Copy link

Coverage Status

coverage: 99.07%. remained the same
when pulling 291bdc5 on depfu/update/rubocop-rails-2.30.2
into 4622395 on main.

Copy link
Contributor Author

depfu bot commented Mar 4, 2025

Closed in favor of #1428.

@depfu depfu bot closed this Mar 4, 2025
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.30.2 branch March 4, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants