Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails71 #1409

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Rails71 #1409

merged 7 commits into from
Feb 10, 2025

Conversation

JPrevost
Copy link
Member

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

YES

@mitlib mitlib temporarily deployed to mit-bento-pr-1409 February 10, 2025 15:08 Inactive
@mitlib mitlib temporarily deployed to mit-bento-pr-1409 February 10, 2025 15:22 Inactive
@coveralls
Copy link

coveralls commented Feb 10, 2025

Coverage Status

coverage: 99.07% (-0.06%) from 99.127%
when pulling 8ac05e4 on rails71
into fbdea98 on main.

Heroku doesn't yet have 3.2.7 available
@mitlib mitlib temporarily deployed to mit-bento-pr-1409 February 10, 2025 15:37 Inactive
@JPrevost JPrevost temporarily deployed to mit-bento-pr-1409 February 10, 2025 15:43 Inactive
@JPrevost JPrevost merged commit c5a0637 into main Feb 10, 2025
3 checks passed
@JPrevost JPrevost deleted the rails71 branch February 10, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants