Support opentelemetry 0.28 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asonix
commented
Feb 17, 2025
| @@ -67,21 +65,24 @@ async fn main() -> io::Result<()> { | |||
| .await?; | |||
|
|
|||
| // Ensure all spans have been shipped to Jaeger. | |||
| opentelemetry::global::shutdown_tracer_provider(); | |||
| provider.shutdown().expect("Failed to shut down provider"); | |||
There was a problem hiding this comment.
shutting down providers now requires passing the provider around
asonix
commented
Feb 17, 2025
| opentelemetry-semantic-conventions = "0.27" | ||
| tracing-opentelemetry = "0.28" | ||
| opentelemetry = "0.28" | ||
| opentelemetry-otlp = { version = "0.28", features = ["grpc-tonic"] } |
There was a problem hiding this comment.
tonic is no longer enabled by default
asonix
commented
Feb 17, 2025
| @@ -2,9 +2,7 @@ use actix_web::{web, App, HttpServer}; | |||
| use opentelemetry::trace::TracerProvider; | |||
| use opentelemetry::{global, KeyValue}; | |||
| use opentelemetry_otlp::WithExportConfig; | |||
| use opentelemetry_sdk::{ | |||
| propagation::TraceContextPropagator, runtime::TokioCurrentThread, trace::Config, Resource, | |||
| }; | |||
There was a problem hiding this comment.
runtime arguments are no longer required (background threads get spawned or something)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138