Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 우.이.삭 체험하기 API 개발 #210

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

BeomSeogKim
Copy link
Contributor

🚀 Pull Request Template 🚀

📝 변경 이유 (Why did you make these changes?)

체험하기 기능 추가

⚠️ 발견된 위험 또는 장애 (Identified Risks or Issues)

없습니다.

👀 리뷰 포커스 (Review Focus)


✅ 테스트 계획 및 완료 사항 (Test Plans & Completed Items)

추가된 사항에 대한 테스트 완료

:octocat: 기타 사항

🙏 리뷰해 주셔서 감사합니다! 🙏

@BeomSeogKim BeomSeogKim self-assigned this Jan 19, 2024
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Test Results

 55 files  +2   55 suites  +2   14s ⏱️ ±0s
259 tests +2  254 ✅ +1  5 💤 +1  0 ❌ ±0 
261 runs  +2  256 ✅ +1  5 💤 +1  0 ❌ ±0 

Results for commit 0e8cf97. ± Comparison against base commit a83f441.

This pull request removes 12 and adds 13 tests. Note that renamed tests count towards both.
com.lovely4k.backend.architect.ArchTests ‑ Service class에는 @Transactional(readOnly=true) 옵션이 붙어 있어야 하며,"
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [1] request=CreateCalendarRequest[startDate=null, endDate=2024-01-17, scheduleDetails=Details, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [1] request=FindCalendarsWithDateRequest[from=null, to=2024-01-17]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [1] request=UpdateCalendarRequest[startDate=null, endDate=2024-01-17, scheduleDetails=Details, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [2] request=CreateCalendarRequest[startDate=2024-01-17, endDate=null, scheduleDetails=Details, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [2] request=FindCalendarsWithDateRequest[from=2024-01-17, to=null]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [2] request=UpdateCalendarRequest[startDate=2024-01-17, endDate=null, scheduleDetails=Details, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [3] request=CreateCalendarRequest[startDate=2024-01-17, endDate=2024-01-17, scheduleDetails=, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [3] request=UpdateCalendarRequest[startDate=2024-01-17, endDate=2024-01-17, scheduleDetails=, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [4] request=CreateCalendarRequest[startDate=2024-01-17, endDate=2024-01-17, scheduleDetails=Details, scheduleType=INVALID_TYPE]
…
com.lovely4k.backend.architect.ArchTests ‑ Service class에는 @Transactional(readOnly=true) 옵션이 붙어 있어야 하며,"
find로 시작하지 않는 public 메서드는 @Transactional 옵션을 붙여 주어야 한다.
com.lovely4k.backend.authentication.LoginServiceTest ‑ trialLogin을 통해 accessToken 값과 refreshToken 값을 받아올 수 있다.
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [1] request=CreateCalendarRequest[startDate=null, endDate=2024-01-19, scheduleDetails=Details, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [1] request=FindCalendarsWithDateRequest[from=null, to=2024-01-19]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [1] request=UpdateCalendarRequest[startDate=null, endDate=2024-01-19, scheduleDetails=Details, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [2] request=CreateCalendarRequest[startDate=2024-01-19, endDate=null, scheduleDetails=Details, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [2] request=FindCalendarsWithDateRequest[from=2024-01-19, to=null]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [2] request=UpdateCalendarRequest[startDate=2024-01-19, endDate=null, scheduleDetails=Details, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [3] request=CreateCalendarRequest[startDate=2024-01-19, endDate=2024-01-19, scheduleDetails=, scheduleType=TRAVEL]
com.lovely4k.backend.calendar.controller.CalendarControllerTest ‑ [3] request=UpdateCalendarRequest[startDate=2024-01-19, endDate=2024-01-19, scheduleDetails=, scheduleType=TRAVEL]
…
This pull request skips 1 test.
com.lovely4k.backend.question.service.QuestionQueryServiceForGameTest ‑ coupleId를 통해서 기존에 답변했던 질문들 중 랜덤으로 하나를 조회할 수 있다.

@BeomSeogKim BeomSeogKim merged commit e00d49d into dev Jan 19, 2024
5 checks passed
@BeomSeogKim BeomSeogKim deleted the feat-member-trial branch January 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant