Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match main updates in dev, Automate certificates, Update to Fastlane 2.225.0 #234

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

marionbarker
Copy link
Contributor

@marionbarker marionbarker commented Jan 26, 2025

Purpose:

Restore dev to a branch that can be used for development while waiting for tidepool-merge to be ready

Status:

  1. Several fixes were added to the main branch when Loop 3.4.4 was released, but not brought into dev
  2. Some submodules in main are at later commits than those same submodules in dev

Actions of this PR:

I broke this into atomic commits:

  1. I copied over the changes made to browser build in main by using git checkout main -- .github/workflows/*.yml(Note - this change was already a PR (fix browser build sync and alive behavior for dev  #175) for this, which was closed in favor of this one)
  2. I used the SHA from Loop PR 2241 to restore TestFlight expiration date
  3. I brought LibreTransmitter, OmniXXX and LoopKit up to the tip of their respective branches
  4. I updated to Fastlane 2.225.0
  5. I copied over the updates from Trio PR 453: Automate handling of Distribution certificates and profiles
    • This was thoroughly tested and demonstrated to work with the Trio repository
    • I imported the required changes and documentation (testflight.md) to bring this to Loop
    • As long as agreements are signed and one variable is added, the creation of Certificates is completely automatic
    • Code for the automated certificate creation must be in the default branch
  6. (2025-02-11) modify the time of day for automatic building to deconflict from other OS apps that also perform automatic certificate updates
    • One of the steps when no valid certificate is found, then run nuke_certs and you only want one app to be doing that at any given time
    • Stagger the times used by different apps to prevent conflicts in the future
  7. (2025-02-12) added the updates to OmniBLE and OmniKit
    • Fixed a logic error where podSuspended might be returned following a communication problem
    • Loop was pretty robust at recovering from this, but this fix should be included to in dev

Because this PR encompasses changes in the (draft) PR that @bjornoleh proposed, that PR #228 was closed.

Testing

  • I built this using Xcode 16.1 onto several test phones and confirmed the expiration data is displayed on the Settings screen
  • I built this using Browser Build and installed on a test phone and confirmed the expiration date is displayed on the Settings screen
  • I tested revoking a certificate and was able to just do the one action: Build Loop; the certificate was automatically generated and build was successful

@marionbarker
Copy link
Contributor Author

@ps2 Can you please review this PR?

@marionbarker
Copy link
Contributor Author

marionbarker commented Mar 3, 2025

  1. (2025-03-03) Update to use macos-15 and Xcode_16.2 to meet the 24 April 2025 requirement imposed by GitHub for actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant