Lookup of abuse-c #904
Merged
Lookup of abuse-c #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafiot
reviewed
Apr 5, 2024
lookyloo/modules/uwhois.py
Outdated
Comment on lines
93
to
96
| #if an abuse-c-Object is found in the whois entry, the result of its lookup will be returned | ||
| abuse_c = re.search(rb'abuse-c:\s+(.*)\s', bytes_whois) | ||
| if abuse_c is not None: | ||
| return self.whois(abuse_c.group(1).decode(), contact_email_only) |
There was a problem hiding this comment.
We probably want to concatenate both requests an return them together, unless contact_email_only is True in which case the emails from the abuse_c response take priority (if they exist).
…abuse-c-lookup is added to the initial lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests should be opened against the
mainbranch. For more information on contributing to Lookyloo documentation, see the Contributor Guidelines.Type of change
Description:
Select the type of change(s) made in this pull request:
Fixes #900
Proposed changes
contact_email_onlyisFalseboth requests will be concatenated