Feature/#41 feature 모듈 분리 코어 디자인시스템 모듈생성 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsakee
added
⭐ [FEAT]
|
이야.... 고생해써 삭브라더 |
codingmy
reviewed
Jan 18, 2024
| @@ -10,6 +11,7 @@ import com.google.android.material.snackbar.Snackbar | |||
| import org.sopt.mainfeature.R | |||
| import org.sopt.mainfeature.databinding.LayoutToasterSnackbarBinding | |||
|
|
|||
| @SuppressLint("RestrictedApi") | |||
codingmy
reviewed
Jan 18, 2024
| @@ -13,8 +13,8 @@ import kotlinx.coroutines.flow.launchIn | |||
| import kotlinx.coroutines.flow.onEach | |||
| import kotlinx.coroutines.launch | |||
| import org.sopt.datastore.datastore.SecurityDataStore | |||
| import org.sopt.mainfeature.MainActivity | |||
| import org.sopt.mainfeature.databinding.ActivityLoginBinding | |||
| import org.sopt.login.databinding.ActivityLoginBinding | |||
There was a problem hiding this comment.
여기에 databinding은 xml에서의 databinding과 다른건가요?? baseFragment이랑 activityFragment에서 databinding을 제거했었던 것으로 기억해서 여기서 쓰이는 databinding은 제가 제거한 databindnig이랑 다른 것인지 궁금합니다!
codingmy
reviewed
Jan 18, 2024
| @@ -74,8 +74,7 @@ class TimerFragment : Fragment() { | |||
|
|
|||
| binding.ivTimerPlus.setOnClickListener { | |||
| parentFragmentManager.commit { | |||
| val exampleTimePickerFragment = ExampleTimePickerFragment() | |||
| replace(R.id.fcv_main, exampleTimePickerFragment) | |||
| // val exampleTimePickerFragment = ExampleTimePickerFragment() | |||
| } | |||
There was a problem hiding this comment.
여기가 실행되면 무엇이 어떻게 되는 코드인가요?? 시간 관련인건 알겠는데 세부적인 실행시 결과를 모르겠어서 질문합니다!
|
진짜 고생하셨습니다!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
feature 모듈 분리 코어 디자인시스템 모듈생성
🌱 작업한 내용
🌱 PR 포인트
📸 스크린샷
📮 관련 이슈