Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#39 clip edit 뷰 / UI 구현 #40

Merged
merged 9 commits into from
Jan 6, 2024
Merged

Conversation

codingmy
Copy link
Contributor

@codingmy codingmy commented Jan 5, 2024

📌 PR 요약

🌱 작업한 내용

  • 툴바 적용
  • 리사이클러뷰 외 ui
  • 리사이클러뷰 item

🌱 PR 포인트

  • 주석처리된 속성은 현재 머지 안된 브랜치에서 정의된 속성 참고 부탁드림당
  • 전체 클립(마이너스, 수정이미지 없음) 이랑 사용자가 생성한 클립(마이너스, 수정이미지 있음) 둘다 하나의 item 을 사용해서 재사용성을 높이려고 하는데 나누는게 나을까요? 아니면 이대로 item 레이아웃 하나로 상황에 따라 visible 조절해서 사용하는게 좋을까요..??

📸 스크린샷

image

📮 관련 이슈

@codingmy codingmy added ⭐ [FEAT] 새로운 기능 구현 민영 안산대장 💟 [UI] UI 작업 xml 파일 건들면 요거 labels Jan 5, 2024
@codingmy codingmy self-assigned this Jan 5, 2024
@codingmy codingmy added this to the ui 작업 milestone Jan 5, 2024
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요

Comment on lines +21 to +30
<androidx.constraintlayout.widget.ConstraintLayout
android:id="@+id/ll_clip_edit_clip"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginStart="8dp"
android:background="@color/white"
android:orientation="horizontal"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@id/iv_clip_edit_delete"
app:layout_constraintTop_toTopOf="parent">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 컨스트레인트 레이아웃 쓴 이유 있나욥?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기가 기능 명세서에서 확인하면 제가 묶은 영역부분을 꾹 누르면 위치 이동이 가능하게 구성되있어서, clicklistener 달려면 해당 터치인식 영역을 layout으로 묶는게 적절하다고 생각해서 cl로 묶었어용

Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsakee lsakee merged commit 9a0ff3b into develop Jan 6, 2024
1 check passed
@lsakee lsakee deleted the feature/#39-clip-edit-ui branch January 6, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ [FEAT] 새로운 기능 구현 민영 안산대장 💟 [UI] UI 작업 xml 파일 건들면 요거
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[ui] clip edit뷰 / UI 작업
3 participants