Feature/#29 clip, clip detail 뷰 / UI 구현 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingmy
changed the title
codingmy
changed the title
codingmy
changed the title
codingmy
changed the title
lsakee
requested changes
Jan 5, 2024
| android:layout_height="match_parent" | ||
| android:background="@color/background"> | ||
|
|
||
| <androidx.appcompat.widget.Toolbar |
Sangwook123
requested changes
Jan 5, 2024
|
|
||
| <androidx.appcompat.widget.AppCompatButton | ||
| android:id="@+id/btn_clip_all" | ||
| android:layout_width="105dp" |
There was a problem hiding this comment.
dp값 지정말고 컨스트레인트 활용해 봅시다 !
| <com.google.android.material.divider.MaterialDivider | ||
| android:id="@+id/dv_clip_picker1" | ||
| android:layout_width="1dp" | ||
| android:layout_height="19dp" |
| <androidx.appcompat.widget.AppCompatButton | ||
| android:id="@+id/btn_clip_read" | ||
| android:layout_width="105dp" | ||
| android:layout_height="38dp" |
There was a problem hiding this comment.
이거 첨에 마진으로 처리할려고 했었을 때 육안상 사이즈가 이상하게 나와서 길이 픽스 준거였는데 일단 다시 마진으로 해서 올릴게영
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" > | ||
| <include layout="@layout/toolbar_clip"/> |
There was a problem hiding this comment.
툴바안에 툴바가 들어있네여 툴바도 그냥 컨스트레인트로 만들어도 될것 같슴다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
🌱 PR 포인트
삽질하다가 끊어가려고 쪼개서 pr 올리는 거라서 현재 작업 안된 부분
작업한 부분
네이밍 가독성을 위해 fragment 네이밍을 clip(category), clip detail(category뷰에서 특정 카테고리 진입시 링크 보여주는 뷰) 으로 변경했는데 그닥인거 같아서 좋은 아이디어 있으면 받습니다~
일단 녹화용으로 clip detail뷰를 home에 옮겨서 녹화떴슴당(커밋안함)
item 구현은 스크린샷 캡쳐 참고
+) 다시보니까 좀더 pr을 쪼개서 올렸어야했네용...담부터는 좀더 쪼개서 올리겠습니다
📸 스크린샷
Screen_Recording_20240105_163051_One.UI.Home.mp4
|파일첨부바람|
📮 관련 이슈