Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#26 component bottomsheet #31

Merged
merged 18 commits into from
Jan 5, 2024
Merged

Conversation

lsakee
Copy link
Contributor

@lsakee lsakee commented Jan 4, 2024

๐Ÿ“Œ PR ์š”์•ฝ

component bottomsheet
๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • component bottomsheet

๐ŸŒฑ PR ํฌ์ธํŠธ
-component bottomsheet

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

|์Šคํฌ๋ฆฐ์ƒท|

component bottomsheet
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@lsakee lsakee added โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿ’Ÿย [UI] UI ์ž‘์—… xml ํŒŒ์ผ ๊ฑด๋“ค๋ฉด ์š”๊ฑฐ ์‚ญ ์•„์ดํ 126 labels Jan 4, 2024
Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

android:layout_height="wrap_content"
android:layout_marginHorizontal="20dp"
android:layout_marginTop="21dp"
app:editTextSearchHint="ํด๋ฆฝ์˜ ์ด๋ฆ„์„ ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”"
Copy link
Contributor

@Sangwook123 Sangwook123 Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์š”๊ฑฐ ์ŠคํŠธ๋ง ์ถ”์ถœ ํ•ด์ฃผ์„ธ์—ฌ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„์š”๋ถ€๋ถ„ ํˆด์Šค ์ž…๋‹ˆ๋‹ค . ๋ฉ”์†Œ๋“œ
์ถ”๊ฐ€ ์˜ˆ์ •์ž…๋‹ˆ๋‹ค

Copy link
Contributor

@CHANGEL1004 CHANGEL1004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ์žก์ž…๋‹ˆ๋‹ค

@@ -30,6 +32,9 @@ class ExamDesignActivity : AppCompatActivity() {
}
}
binding.etv.apply {
onClickTextClear {
Timber.d("SaK")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‹œํฌํ•˜๋„ค์š”

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•จ์ˆ˜ํ™” ๊น”๋”ํ•˜๋„ค์š”

@lsakee lsakee merged commit b3a8ac4 into develop Jan 5, 2024
@lsakee lsakee deleted the feature/#26-component-bottomsheet branch January 5, 2024 21:20
@CHANGEL1004 CHANGEL1004 added this to the ui ์ž‘์—… milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ์‚ญ ์•„์ดํ 126 ๐Ÿ’Ÿย [UI] UI ์ž‘์—… xml ํŒŒ์ผ ๊ฑด๋“ค๋ฉด ์š”๊ฑฐ
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] bottom sheet component
3 participants