Feature/#20 mypage UI #25

CHANGEL1004 · 2024-01-04T09:20:30Z

📌 PR 요약

🌱 작업한 내용

마이페이지 뷰 구현

🌱 PR 포인트

100% 완성은 아님미다

📸 스크린샷

📮 관련 이슈

Resolved: [feat] mypage 구현 / UI 구현 #21

Sangwook123

고생하셨슴다 리뷰 확인 바람니당!

Sangwook123 · 2024-01-04T12:48:18Z

feature/mainfeature/build.gradle.kts

@@ -15,7 +15,8 @@ dependencies {
  implementation(libs.appcompat)
  implementation(libs.material)
  implementation(libs.constraintlayout)
-  testImplementation(libs.junit)
+    implementation(project(":core:datastore"))


이거 지워주세여

Sangwook123 · 2024-01-04T12:48:45Z

feature/mainfeature/src/main/res/drawable/bg_mypage_line.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<shape xmlns:android="http://schemas.android.com/apk/res/android">


shape 컨벤션 맞춰주세요 ~

Sangwook123 · 2024-01-04T12:49:00Z

feature/mainfeature/src/main/res/drawable/bg_mypage_link.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<shape xmlns:android="http://schemas.android.com/apk/res/android">


Sangwook123 · 2024-01-04T12:50:43Z

feature/mainfeature/src/main/res/drawable/ic_count_background.xml

+    android:height="83dp"
+    android:viewportWidth="320"
+    android:viewportHeight="83">
+  <path


이건 어디서 쓰이고 있나요?

Sangwook123 · 2024-01-04T12:51:32Z

gradle/libs.versions.toml

@@ -1,5 +1,5 @@
 [versions]
-android-gradle-plugin = "8.1.2"
+android-gradle-plugin = "8.2.0"


agp 버전 다시 돌려놔주세여

Sangwook123 · 2024-01-04T12:51:46Z

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 #Thu Dec 21 03:12:17 KST 2023
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-bin.zip


Sangwook123 · 2024-01-04T12:54:09Z

feature/mainfeature/src/main/res/layout/fragment_my.xml

+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="4dp"
+        android:hint="@string/my_please_wait"


텍스트뷰 중앙정렬 시켜주세요

Sangwook123 · 2024-01-04T12:56:12Z

feature/mainfeature/src/main/res/values/strings.xml

@@ -5,4 +5,10 @@
  <string name="text_timer">TIMER</string>
  <string name="text_my">MY</string>
  <string name="text_placeholder">placeholder</string>
+  <!-- mypage -->
+  <string name="my_link_number_now">지금 까지 읽은 링크수</string>


my -> mypage가 더 나을것 같아여

Sangwook123 · 2024-01-04T12:59:49Z

feature/mainfeature/src/main/res/layout/fragment_my.xml

+
+      <TextView
+        android:id="@+id/tv_now_link"
+        style="@style/Typography.suit.regular_18"


textappearance 사용해주세요 ! 그리고 텍스트별로 컬러도 지정해주세요 ~

lsakee

컨벤션 보삼

lsakee · 2024-01-04T12:56:16Z

gradle/libs.versions.toml

@@ -1,5 +1,5 @@
 [versions]
-android-gradle-plugin = "8.1.2"
+android-gradle-plugin = "8.2.0"


요부분은 바꾸지 마세욥

lsakee · 2024-01-04T12:57:38Z

feature/mainfeature/src/main/res/drawable/bg_mypage_link.xml

+<shape xmlns:android="http://schemas.android.com/apk/res/android">
+
+  <corners android:radius="12dp"/>
+  <solid android:color="#F2F2F2"/>


이거 컬러에 없나유?

네이밍 컨벤션 맞춰주세요

추가했으용

lsakee

레이아웃 뷰그룹 활용 더해보아요

lsakee · 2024-01-04T13:10:31Z

feature/mainfeature/src/main/res/layout/fragment_my.xml

+  <LinearLayout
+    android:id="@+id/ll_mypage_now_link"
+    android:layout_width="match_parent"
+    android:layout_height="0dp"
+    android:orientation="vertical"
+    app:layout_constraintBottom_toBottomOf="parent"
+    app:layout_constraintTop_toBottomOf="@id/cl_mypage_title">


이부분 제거해주세요

lsakee · 2024-01-04T13:10:49Z

feature/mainfeature/src/main/res/layout/fragment_my.xml

+  <androidx.constraintlayout.widget.ConstraintLayout
+    android:id="@+id/cl_mypage_title"
    android:layout_width="match_parent"
-    android:layout_height="match_parent"
-    tools:context=".my.MyFragment">
+    android:layout_height="56dp"
+    app:layout_constraintEnd_toEndOf="parent"
+    app:layout_constraintStart_toStartOf="parent"
+    app:layout_constraintTop_toTopOf="parent" />


컨스트레인트 레이아웃으로 충분히 구현 가능해 보입니다

lsakee · 2024-01-04T13:11:05Z

feature/mainfeature/src/main/res/layout/fragment_my.xml

+    <androidx.constraintlayout.widget.ConstraintLayout
+      android:id="@+id/cl_mypage_this_week"
+      android:layout_width="match_parent"
+      android:layout_height="wrap_content">


요런 것들 필요 없지 않나요?

lsakee · 2024-01-04T13:11:32Z

feature/mainfeature/src/main/res/layout/fragment_my.xml

+    <androidx.constraintlayout.widget.ConstraintLayout
+      android:id="@+id/cl_mypage_please_wait"
+      android:layout_width="match_parent"
+      android:layout_height="match_parent">


요런 것도 공기계있으면 개발자 모드로 한번 보시면 이해가 될거 같습니다

Marchbreeze · 2024-01-04T18:38:33Z

이집 코리 야무지네요 ~~~

codingmy · 2024-01-05T10:19:15Z

feature/mainfeature/src/main/res/layout/fragment_my.xml

+  <androidx.constraintlayout.widget.ConstraintLayout
+    android:id="@+id/cl_mypage_title"
    android:layout_width="match_parent"
-    android:layout_height="match_parent"
-    tools:context=".my.MyFragment">
+    android:layout_height="56dp"
+    app:layout_constraintEnd_toEndOf="parent"
+    app:layout_constraintStart_toStartOf="parent"
+    app:layout_constraintTop_toTopOf="parent" />
+


이 cl_mypage_title 여기서 아무것도 안 담기고 태그 닫힌거 같은데 확인부탁드려요!

codingmy · 2024-01-05T10:21:44Z

feature/mainfeature/src/main/res/layout/fragment_my.xml

+      android:id="@+id/v_mypage_1"
+      android:layout_width="match_parent"
+      android:layout_height="4dp"
+      android:background="#F2F2F2"


이 색상코드 부분 color 네임으로 넣어주면 가독성이 더 좋아질거 같아요!

없는 줄 알았는데 있더라구여 추가했어유!~!

codingmy · 2024-01-05T10:27:07Z

feature/mainfeature/src/main/res/values/typography.xml

+  <style name="circleImageView">
+    <item name="cornerFamily">rounded</item>
+    <item name="cornerSize">50%</item>
+  </style>
+


이 친구는 이미지뷰 관련 스타일인가용??

넹 맞아용

codingmy · 2024-01-05T10:27:47Z

수고하셨슴당!~!

lsakee

LGTM

Sangwook123

LGTM

CHANGEL1004 added 7 commits January 4, 2024 01:19

[add] : #20 아이콘 리소스 추가

7669eff

[add] : #20 리소스 추가

a843c7c

[chore] : #20 라이브러리 추가

df3f1ad

[ui] : #20 테스트 이미지 추가

17cc77a

[ui] : #20 fragment_my 뷰

1a6d01a

[ui] : #20 스트링 리소스, 스타일 추가

980eb84

[chore] : #20 파일 변경

18da226

CHANGEL1004 added ⭐ [FEAT] 새로운 기능 구현 채은 금쪽이 💟 [UI] UI 작업 xml 파일 건들면 요거 labels Jan 4, 2024

CHANGEL1004 added this to the ui 작업 milestone Jan 4, 2024

CHANGEL1004 requested review from lsakee, codingmy and Sangwook123 January 4, 2024 09:20

CHANGEL1004 self-assigned this Jan 4, 2024

Sangwook123 requested changes Jan 4, 2024

View reviewed changes

lsakee requested changes Jan 4, 2024

View reviewed changes

CHANGEL1004 added 4 commits January 5, 2024 02:38

[chore] : #20 변경사항 복구 및 제거

f451949

[del] : #20 불필요한 파일 삭제

f64c4b8

[refactor] : #20 파일명 수정

543804d

[chore] : #20 스트링 리소스 수정

72c5e38

codingmy reviewed Jan 5, 2024

View reviewed changes

CHANGEL1004 added 2 commits January 5, 2024 22:54

[refactor] : #20 레이아웃 파일 수정

f6a2eae

Merge branch 'develop' into feature/#20-mypage-ui

1e851dd

lsakee approved these changes Jan 6, 2024

View reviewed changes

Sangwook123 approved these changes Jan 6, 2024

View reviewed changes

lsakee merged commit db85386 into develop Jan 6, 2024
1 check passed

lsakee deleted the feature/#20-mypage-ui branch January 6, 2024 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/#20 mypage UI #25

Feature/#20 mypage UI #25

CHANGEL1004 commented Jan 4, 2024 •

edited

Loading

Sangwook123 left a comment

Sangwook123 Jan 4, 2024

Sangwook123 Jan 4, 2024

Sangwook123 Jan 4, 2024

Sangwook123 Jan 4, 2024

CHANGEL1004 Jan 4, 2024

Sangwook123 Jan 4, 2024

CHANGEL1004 Jan 4, 2024

Sangwook123 Jan 4, 2024

Sangwook123 Jan 4, 2024

Sangwook123 Jan 4, 2024

Sangwook123 Jan 4, 2024

lsakee left a comment

lsakee Jan 4, 2024

CHANGEL1004 Jan 4, 2024

lsakee Jan 4, 2024

lsakee Jan 4, 2024

CHANGEL1004 Jan 4, 2024

lsakee left a comment

lsakee Jan 4, 2024

lsakee Jan 4, 2024

lsakee Jan 4, 2024

lsakee Jan 4, 2024

Marchbreeze commented Jan 4, 2024

codingmy Jan 5, 2024

codingmy Jan 5, 2024 •

edited

Loading

CHANGEL1004 Jan 6, 2024

codingmy Jan 5, 2024

CHANGEL1004 Jan 6, 2024

codingmy commented Jan 5, 2024

lsakee left a comment

Sangwook123 left a comment

		@@ -0,0 +1,5 @@
		<?xml version="1.0" encoding="utf-8"?>
		<shape xmlns:android="http://schemas.android.com/apk/res/android">

		@@ -0,0 +1,6 @@
		<?xml version="1.0" encoding="utf-8"?>
		<shape xmlns:android="http://schemas.android.com/apk/res/android">

Feature/#20 mypage UI #25

Feature/#20 mypage UI #25

Conversation

CHANGEL1004 commented Jan 4, 2024 • edited Loading

📌 PR 요약

📸 스크린샷

📮 관련 이슈

Sangwook123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsakee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsakee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Marchbreeze commented Jan 4, 2024

Choose a reason for hiding this comment

codingmy Jan 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codingmy commented Jan 5, 2024

lsakee left a comment

Choose a reason for hiding this comment

Sangwook123 left a comment

Choose a reason for hiding this comment

CHANGEL1004 commented Jan 4, 2024 •

edited

Loading

codingmy Jan 5, 2024 •

edited

Loading