[Fix] 타이머 요일 정렬해서 저장 #207
Merged
[Fix] 타이머 요일 정렬해서 저장 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Merge] 정규표현식 수정 후 merge
sss4920
approved these changes
Jan 19, 2024
| @@ -70,6 +70,8 @@ public void createTimer(Long userId, CreateTimerRequestDto createTimerRequestDto | |||
| throw new CustomException(Error.UNPROCESSABLE_CREATE_TIMER_EXCEPTION, Error.UNPROCESSABLE_CREATE_TIMER_EXCEPTION.getMessage()); | |||
| } | |||
|
|
|||
| createTimerRequestDto.remindDates().sort(Comparator.naturalOrder()); | |||
There was a problem hiding this comment.
오..naturalOrder 이런 것도 있군요 찾아보겠습니다. 저도..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
타이머 조회할때 요일이 정렬되지않으면 정렬되어 나타나서 정렬하여 저장하는 로직으로 변경했습니다.
어떤 부분에 리뷰어가 집중해야 하는지
개발하면서 어떤 점이 궁금했는지
📸 결과물 스크린샷
🛠️ 테스트
🚀 API Endpoint