noninteractive-tradefed: stop using the latest adb #496
Conversation
|
HI, @bhcopeland @roxell |
|
share with @sumitsemwal as well |
|
Can you please elaborate how this fixes the issue, and what is the issue in your commit message. |
instead using the default version in the system, either installed by the user manually or installed inside some docker image, to avoid confusions caused by unmanaged adb versions, like the "ADB server didn't ACK" issue with the current latest adb version(platform-tools r35) reported here: https://lkft.validation.linaro.org/scheduler/job/7266683#L15671 Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
updated the commit message now, the "ADB server didn't ACK" issue is related to the latest adb version(platform-tools r35), |
|
Hi, @bhcopeland @roxell Just want to check, do you have any other concerns on this change to have it merged? |
|
Won't it be better to pin the version rather than relay on the version on the dispatcher? |
|
Yongqin it would have probably helped to link to the docker image here for context https://review.linaro.org/c/ci/dockerfiles/+/46721 |
|
oh thank you @bhcopeland I missed that dockerfile change. |
instead using the default version in the system,
either installed by the user manually or installed
inside some docker image, to avoid confusions caused by
unmanaged adb versions, like the "ADB server didn't ACK"
issue with the current latest adb version(platform-tools r35)
reported here:
https://lkft.validation.linaro.org/scheduler/job/7266683#L15671