Yan/lbm1 17384 - reconnecto to rabbitmq in case of failure #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disable main loop while reconnecting - do not set connection as finished on reconnect - invoke cleanup in rabbitmq connection thread Signed-off-by: Yan <yan@lightbitslabs.com>
Signed-off-by: Yan <yan@lightbitslabs.com>
amittar-lb
reviewed
Aug 31, 2021
Comment on lines
+90
to
+91
| except Exception as e: | ||
| logging.exception("Couldnt to reconnect RabbitMQ.") |
There was a problem hiding this comment.
I think it will be good to log the exception itself as well. (f"Couldnt to reconnect RabbitMQ. Reaseon: {e}")
It can help us understand why the connection failed.
Other then that - looks good!
There was a problem hiding this comment.
Thanks.
Yes, I used logging.exception for that: https://stackoverflow.com/a/5191885
"logger.exception will output a stack trace alongside the error message."
I think it should be enough
|
@yuval-lb ping 👍 |
amittar-lb
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As seen on ticket #LBM1-17384 we got sometimes failures in while calling t rabbitmq.
I've implemented a reconnection that is being done on the Connection thread.
Currently it tries to reconnect once, if it fails it will continue with the original failure flow (i.e set pdb trace)
Tests
Iv'e created a test branch: https://github.com/LightBitsLabs/inaugurator/tree/yan/LBM1-17384-TEST which is a branch of the current branch.
Basically what it does, is throwing the ConnectionClosed exception once in the code (in order to fail the run in the first time, then in the second run it will reconnect and reproduce the original function)
The tests were done on rack03-server61
I've tested the following flows: