Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.7 gradle build process #553

Open
wants to merge 4 commits into
base: MC1.7
Choose a base branch
from

Conversation

flashgnash
Copy link

Replace forgegradle with antawa as forgegradle no longer works (URLs have gone dead)

Update gradle to more recent version

Update voltzengine

Add nix flake with correct java version for compilation along with .envrc for nix & direnv users

flashgnash and others added 4 commits December 13, 2024 15:35
update to anatawa forgegradle
update gradle to 7.6.1
update voltzengine to fix dead dependency
@LemADEC
Copy link
Owner

LemADEC commented Jan 24, 2025

  • Codacy is failing, I suspect it's due to your MR having no source changes, only build chain and metadata. I've opened a support request to them to confirm, we'll see.
  • Your commits are cancelling each others : consider squashing or cleaning ?
  • Nix Flake is related to your IDE space, each dev like to have their own flavor of such things. Consider exporting your configuration or document how to create it, and remove related file from your commits ?

@flashgnash
Copy link
Author

Nix flake is designed to go in source control, it defines all the dependencies and exact versions used so it's reproduceable by other devs in the future (everything needed for said configuration is included in source, all you need is the nix package manager installed on any distro or WSL and you run nix develop to make a temporary shell with correct version of jre and other deps. Not related to IDE, I don't even use an IDE

Is there a way to squash commits without re-creating the PR? Haven't actually done that before I tend to just keep all commits in my repos

@LemADEC
Copy link
Owner

LemADEC commented Jan 25, 2025

you can do an interactive rebase in your IDE or through the command line, check for example https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d of whatever your search engine may find on your favorite site :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants