Feature Request / Fix: Energy Control Mod Compat #551
Conversation
Add handling for Energy Control mod 1.12.2, Version 0.3.2. Compat added to CompatEnergyControl.java. - Correctly calculates new screen min/max. - Rotates screens, screen extenders, and temperature monitors properly through their NBT. - Recalculates X/Y/Z reference in extenders. - Update inserted data cards, if the referenced coordinate is onboard. In addition, default config entries have been added to place screen extenders before main screen, to avoid main screen disconnecting from the extenders.
It also utilizes directional data in NBT, and require update to the inserted card.
This caused error spam. Furthermore, it seems to be not needed with the placement order set in the config.
|
@LemADEC Please kindly review the above PR/Changes. Thanks. |
| @@ -373,7 +377,7 @@ public BlockPos deploy(final World worldSource, final World worldTarget, final I | |||
| nbtToDeploy.setTag("screenData", nbtScreenData); | |||
| } | |||
| } | |||
|
|
|||
| */ | |||
There was a problem hiding this comment.
Consider removing the legacy NuclearControl code altogether?
|
|
||
| private static Class<?> classRangeTrigger; //Range Trigger | ||
|
|
||
| public static void register(){ |
There was a problem hiding this comment.
Consider following existing code spacing rules?
- tabulation -> space
- space before and after { } + - / etc.
- first condition on the same line as if
- then instruction always on a different line than the if
- case aligned (not indented) vs switch statement
- etc.
| private static final byte[] horizontalRotFacing = { 1, 2, 3, 0, 5, 6, 7, 4, 8, 9, 10, 11, 12, 13, 14, 15}; | ||
|
|
||
| @Override | ||
| public int rotate(Block block, int metadata, NBTTagCompound nbtTileEntity, ITransformation transformation) { |
There was a problem hiding this comment.
Parameters should all be final by default, consider updating accordingly?
| classRangeTrigger = Class.forName("com.zuxelus.energycontrol.blocks.RangeTrigger"); | ||
| WarpDriveConfig.registerBlockTransformer("energycontrol", new CompatEnergyControl()); | ||
| }catch(final ClassNotFoundException exception){ | ||
| WarpDrive.logger.error(exception); |
There was a problem hiding this comment.
Consider printing the stack trace like other compatibility module do?
| classRemoteThermalMonitor.isInstance(block) || | ||
| classRangeTrigger.isInstance(block) | ||
| ){ | ||
| NBTTagList items = nbtTileEntity.getTagList("Items", 10); |
There was a problem hiding this comment.
Avoid harcoded values, consider using the NBTType.xxx related constant instead?
| itemTag.setInteger("x", result.getX()); | ||
| itemTag.setInteger("y", result.getY()); | ||
| itemTag.setInteger("z", result.getZ()); | ||
| item.setTag("tag", itemTag); |
There was a problem hiding this comment.
This modify the original item, then overwrite it with a copy, consider skipping the copy and just modify in place? and by extension, no need to call itemsNew.set() and using anyChange boolean either...
This pull request implemented:
It have been brought to attention that there is multiple compatibility issues with the mod Energy Control, specifically when blocks from this mod is installed and used on ships. The problem is as follows:
BlockDirectional, more advanced block would fail to properly rotate, as their actual direction of functionality is dictated by the propertyrotationandfacingin its NBT. This includes the screen, and also the thermal monitor - the latter has caused explosive consequences on a ship with IC2 nuclear reactor as its main power.This PR have implemented compatibility patch to fix the above issue. The patch is implemented in
CompatEnergyControl.java.facing(the physical orientation of the block) androtation(which dictates the 'up' direction of texts on a screen, when the screen is placed on floor or ceiling.)JumpBlock.java.coreX/Y/Zfield, updated. This fix the issue where sometimes extenders can no longer be right clicked (or worse, cause a crash) after a jump.Additionally,
These modifications will allow Energy Control displays and devices to operate normally while onboard a ship.