Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with JSG + Update build.gradle #546

Open
wants to merge 14 commits into
base: MC1.12
Choose a base branch
from

Conversation

jhammerberg
Copy link

Added compatibility with Just Stargate Mod. Allows for the movement of the Stargate multiblock without breaking any functionality. Also rotates the DHD properly.

I also fixed some URLs not resolving in the build.gradle and made the development instructions more clear in the README.md

@jhammerberg
Copy link
Author

90% of this is now redundant because JSG just made a new release that reforms the multiblock when a ship jumps. The Stargate state check is still helpful in preventing a crash.

Copy link
Owner

@LemADEC LemADEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please clarify if any of those JSG changes are still needed?

build.gradle Outdated
provided "GC-1.12-dev:GalacticraftCore-Dev:${config.Galacticraft_version}.${config.Galacticraft_build}"
// provided "GC-1.12-dev:GalacticraftCore-Dev:${config.Galacticraft_version}.${config.Galacticraft_build}"
provided "dev.galacticraft:galacticraft-legacy:${config.Galacticraft_version}"
provided "curse.maven:icbm-classic-244451:4524395"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version is obfuscated and hardcoded in build script, consider adding a comment on the actual version and leaving version dependencies in the separate config file? (multiple occurrences)

@jhammerberg
Copy link
Author

Apologies for the unnecessary changes, this was my first time doing a pull request and Java development and I didn't know how to only include the pertinent changed files. The changes are still necessary, although the new version of JSG reassembles the multiblock when jumped, it doesn't take into account rotation still which this compatibility module does.

@LemADEC
Copy link
Owner

LemADEC commented Aug 1, 2023

You can push new commits that revert the unnecessary changes and, eventually, squash them with git to remove all traces of that temporary blip. In the end, we only want the good working code, we don't care about intermediary development bugs or whatnot.

@jhammerberg
Copy link
Author

I've made the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants