Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve perf of blob retrieval within bucket #1329

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Feb 26, 2025

Why are these changes needed?

This is perf optimization for blob feed retrieval:

  • Apply limit to within bucket retrieval
    • e.g. if the client wants just 1 blob, it won't need to exhaust the entire bucket (which can have up to 360,000 blobs, assuming 100 blobs/ and 1h per bucket)
  • Avoid allocating additional slice

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from dmanc and ian-shim February 26, 2025 01:10
@jianoaix jianoaix merged commit 25c2e09 into Layr-Labs:master Feb 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants