Support backward iteration for blob feed #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
commented
Feb 22, 2025
| @@ -354,7 +354,7 @@ func (s *BlobMetadataStore) queryBucketBlobMetadata( | |||
| } | |||
|
|
|||
| // GetBlobMetadataByRequestedAtForward returns blobs (as BlobMetadata) in cursor range | |||
| // (after, until] (after exclusive, until inclusive). Blobs are ordered by <RequestedAt, BlobKey> | |||
| // (after, until) (both exclusive). Blobs are ordered by <RequestedAt, BlobKey> | |||
There was a problem hiding this comment.
Making both ends exclusive, because:
- it's easier for the feed API implementation
- this is at nanosecond level (the highest resolution), so inclusive use cases can just make a
[L-1, R+1]adjustment which will work correctly (at nanosecond, there is no time points betweenL-1andL)
merli-eigenlabs
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This actually adds support for backward blob feed API (the API added in #1286).
This will make it simple and deterministic to support use cases that need to retrieve blobs backward along the timeline.
Checks