nits

Layr-Labs · Feb 27, 2025 · fd45871 · fd45871
1 parent 96baa64
commit fd45871
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/contracts/script/deploy/certverifier/CertVerifierDeployer.s.sol b/contracts/script/deploy/certverifier/CertVerifierDeployer.s.sol
@@ -18,7 +18,7 @@ import "forge-std/Script.sol";
 import "forge-std/StdJson.sol";
 import "src/interfaces/IEigenDAStructs.sol";
 
-//forge script script/deploy/certverifier/CertVerifierDeployer.s.sol:CertVerifierDeployer --sig "run(string)" <config.json> --rpc-url $RPC --private-key $PRIVATE_KEY -vvvv --etherscan-api-key $ETHERSCAN_API_KEY --verify --broadcast
+//forge script script/deploy/certverifier/CertVerifierDeployer.s.sol:CertVerifierDeployer --sig "run(string, string)" <config.json> <output.json> --rpc-url $RPC --private-key $PRIVATE_KEY -vvvv --etherscan-api-key $ETHERSCAN_API_KEY --verify --broadcast
 contract CertVerifierDeployer is Script, Test {
 
     address eigenDACertVerifier;
@@ -32,9 +32,9 @@ contract CertVerifierDeployer is Script, Test {
     SecurityThresholds defaultSecurityThresholds;
     bytes quorumNumbersRequired;
 
-    function run(string memory json) external {
+    function run(string memory json, string memory outputPath) external {
 
-         string memory path = string.concat("./script/deploy/certverifier/config/", json);
+        string memory path = string.concat("./script/deploy/certverifier/config/", json);
         string memory data = vm.readFile(path);
 
         bytes memory raw = stdJson.parseRaw(data, ".eigenDAServiceManager");
@@ -76,7 +76,7 @@ contract CertVerifierDeployer is Script, Test {
 
         console.log("Deployed new EigenDACertVerifier at address: ", eigenDACertVerifier);
 
-        string memory outputPath = "script/deploy/certverifier/output/certverifier_deployment_data.json";
+        string memory outputPath = string.concat("./script/deploy/certverifier/output/", outputPath);
         string memory parent_object = "parent object";
         string memory finalJson = vm.serializeAddress(parent_object, "eigenDACertVerifier", address(eigenDACertVerifier));
         vm.writeJson(finalJson, outputPath);

diff --git a/contracts/script/deploy/certverifier/README.md b/contracts/script/deploy/certverifier/README.md
@@ -1,6 +1,6 @@
 ## EigenDA Cert Verfier Deployer
 
-This script can be used to deploy an EigenDACertVerifier contract with specified security thresholds and quorum numbers required
+This script can be used to deploy an EigenDACertVerifier contract with custom security thresholds and quorum numbers. The deployment should only be performed on Ethereum L1 testnet or mainnet environment and is not supported on L2s.
 
 ### Config
 
@@ -27,10 +27,10 @@ Two sample configs are provided in the `config/` folder for preprod and testnet
 
 ### Deployment
 
-To deploy the contract, run the following command passing in the path to the config file and appropriate keys
+To deploy the contract, run the following command passing in the path to the config file, the output path, and appropriate keys
 
 ```bash
-forge script script/deploy/certverifier/CertVerifierDeployer.s.sol:CertVerifierDeployer --sig "run(string)" <config.json> --rpc-url $RPC --private-key $PRIVATE_KEY -vvvv --etherscan-api-key $ETHERSCAN_API_KEY --verify --broadcast
+forge script script/deploy/certverifier/CertVerifierDeployer.s.sol:CertVerifierDeployer --sig "run(string, string)" <config.json> <output.json> --rpc-url $RPC --private-key $PRIVATE_KEY -vvvv --etherscan-api-key $ETHERSCAN_API_KEY --verify --broadcast
 ```
 
 The deployment will output the address of the deployed contract to a json file in the `output/` folder named `certverifier_deployment_data.json`