-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to 1.21 #227
Port to 1.21 #227
Conversation
Since Sodium 0.6 has FRAPI support now, double check to make sure flat lighting and such work correctly with the Indigo/Indium "always-tesselate-blocks" mode enabled (if that exists in 0.6), #224 had to be made because of this. |
Sodium’s renderer has no concept of “always tesselate blocks”; both FRAPI and Vanilla models render using identical paths. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@IMS212 I tried to build LambDynamicLights with your ported version of pridelib. I got it to compile but it's still crashing when I open LambDynamicLights' settings in-game with Mod Menu. I don't know if it's related to pridelib or the 1.21 port of LambDynamicLights and I don't currently have the time to investigate but if I find anything, I'll reply here. |
I also complied it and I'm not getting any crashes when opening the modmenu settings. |
Thanks for the update @IMS212 😃 |
This comment was marked as off-topic.
This comment was marked as off-topic.
I am attempting to compile this for testing, but I am unable to generate a jar file from the repository as-is. Gradle throws the following message:
Reading megabyte6's comment led me to your pridelib branch for 1.21, which I was able to compile successfully. But when I updated the dependency for it in the LambDynamicLights project, I am still unable to compile. I receive this:
I am not sure how to proceed from here. Gradle is entirely new to me, so I am most likely approaching this process incorrectly. Any help would be greatly appreciated. |
@SonicGal I'm also basically new at gradle, but for me after compiling the 1.21 pridelib branch I put the pridelib .jar into a folder I made called
and then it builds successfully. |
Thank you so much! This was initially not working because other answers/documentation I found online suggested this needed to be added and/or the dependency line needed to be changed, so I had |
Hello! Not sure if I understand the state of this PR, is something needs to be done before it can get merged? I can help if needed |
@arsel-5lvxa7b1 from my understanding, it pretty much just has to be merged. I don't think there are any outstanding issues besides pridelib not being updated on the official repo. |
Does anyone else experience issues with the graphic settings menu? After using this version with the 1.21 pridelib version, clicking on the Edit: This is bypassed by using Sodium. Still, this is suboptimal behavior and I can not really find a solution in the mixins. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Before any of you all get too excited that this PR is merged, there's still other things that need to be done before release. |
too late, I'm already excited |
Ported to yarn mappings and added Sodium 0.6 support.