chore: optimize cargo workspace settings #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move global settings, `edition`, `version` to the root `Cargo.toml`. - add the dir `/examples` as workspace members, and add `multi-plugin` as cargo example target. - move examples profile settings to root `Cargo.toml` (because the profile settings only work in the root `Cargo.toml`) - set the members of workspace to inherit settings from the root `Cargo.toml`. - update `Cargo.lock` (because of examples deps). - remove `examples/Cargo.lock` (of course, `examples` now is a member of workspace, so it can not have lock file). - reformat all the Cargo file with taplo.
pk5ls20
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the title: optimize the workspace settings
edition,versionto the rootCargo.toml./examplesas workspace members, and addmulti-pluginas cargo example target.Cargo.toml(because the profile settings only work in the rootCargo.toml)Cargo.toml.Cargo.lock(because of examples deps).examples/Cargo.lock(of course,examplesnow is a member of workspace, so it can not have lock file).