LibWeb: Make PolicyContainer GC allocated #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtkinsSJ
approved these changes
Feb 20, 2025
| if (Fetch::Infrastructure::is_local_url(response_url) && initiator_policy_container.has_value()) | ||
| return *initiator_policy_container; | ||
| if (Fetch::Infrastructure::is_local_url(response_url) && initiator_policy_container) | ||
| return initiator_policy_container->clone(realm); | ||
|
|
||
| // 4. If responsePolicyContainer is not null, then return responsePolicyContainer. | ||
| // FIXME: File a spec issue to say "a clone of" here for consistency |
There was a problem hiding this comment.
Probably worth doing this now if you haven't already.
There was a problem hiding this comment.
Done: whatwg/html#11060
This is required to store Content Security Policies, as their Directives are implemented as subclasses with overridden virtual functions. Thus, they cannot be stored as generic Directive classes, as it'll lose the ability to call overridden functions when they are copied.
AtkinsSJ
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of splitting up #2854
This is required to store Content Security Policies, as their Directives are implemented as subclasses with overridden virtual functions. Thus, they cannot be stored as generic Directive classes, as it'll lose the ability to call overridden functions when they are copied.