Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feautre/adapt opt #565

Draft
wants to merge 100 commits into
base: feature/min-err
Choose a base branch
from
Draft

Feautre/adapt opt #565

wants to merge 100 commits into from

Conversation

Steven-Roberts
Copy link
Collaborator

Draft status while doing performance comparisons.

This branches of offfeature/rk_defaults with feature/min-err merged in.

Current adaptivity controller changes:

  • No deadzone
  • Bias: 1.0
  • Safety factor: 0.9
  • Adjustment: 0
  • I controller for ARKStep and ERKStep (to be changed based on Sylvia’s testing)

drreynolds
drreynolds reviewed Sep 10, 2024
View reviewed changes
Steven-Roberts and others added 24 commits January 10, 2025 18:47
@Steven-Roberts
Update double precision out files
a3c9627
@Steven-Roberts
Update ark_heat1D_omp.out
9247376
@gardner48
update fortran output files
2ebbd6e
@drreynolds
merged upstream changes
ceee086
@drreynolds
Cleaned up merge issues
e3cc34c
@Steven-Roberts
Merge branch 'develop' into feature/rk_defaults
5d14239
@Steven-Roberts
Merge branch 'develop' into feature/rk_defaults
daf6a11
@Steven-Roberts
Update logging out files
7c765a3
@Steven-Roberts
Update single precision out files
1b27b2c
@Steven-Roberts
Update level 3 logging out files
e2ea6e8
@Steven-Roberts
Update level 4 logging out files
094c9b1
@Steven-Roberts
Update level 5 logging out files
d7f2eb5
@Steven-Roberts
Update double precision out files
bc7ff83
@Steven-Roberts
Merge branch 'develop' into feature/rk_defaults
6f40ec0
@gardner48
update output files
71fa6c7
@gardner48
update answers submodule
42e86cb
@gardner48
Merge branch 'develop' into feature/rk_defaults
479bf3b
@Steven-Roberts
Adjust ark_heat1D_omp to be more suitable for single precision. Hopef…
af5f5e3 
…ully fixes inconsistent CI test results
@Steven-Roberts
Update ark_heat1D_omp out files
6ed0bfd
@gardner48
Merge branch 'develop' into feature/rk_defaults
2600884
@gardner48
Merge branch 'develop' into feature/rk_defaults
a097c51
@gardner48
update ark_heat1D_omp output
7f2c641
@Steven-Roberts
Merge branch 'feature/rk_defaults' into feautre/adapt-opt
7ce9bd8
@Steven-Roberts
Fix broken links when building pdf
0292f28
Base automatically changed from feature/rk_defaults to develop February 12, 2025 14:48
@Steven-Roberts Steven-Roberts mentioned this pull request Feb 13, 2025
Open
@Steven-Roberts Steven-Roberts changed the base branch from develop to feature/min-err February 14, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drreynolds drreynolds drreynolds left review comments

@balos1 balos1 Awaiting requested review from balos1 balos1 will be requested when the pull request is marked ready for review balos1 is a code owner

@gardner48 gardner48 Awaiting requested review from gardner48 gardner48 will be requested when the pull request is marked ready for review gardner48 is a code owner

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward will be requested when the pull request is marked ready for review cswoodward is a code owner

Assignees

@drreynolds drreynolds

Labels
pkg-ARKODE
Projects
None yet
Milestone
SUNDIALS Next
Development

Successfully merging this pull request may close these issues.
4 participants
@Steven-Roberts @drreynolds @balos1 @gardner48