Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update udigest #41

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Update udigest #41

merged 7 commits into from
Jun 20, 2024

Conversation

survived
Copy link
Contributor

@survived survived commented Jun 17, 2024 •
edited
Loading

Changelog pipeline is failing, but there's nothing to add to changelog in this case

survived
survived commented Jun 17, 2024
View reviewed changes
@survived survived marked this pull request as ready for review June 17, 2024 13:54
@survived survived requested a review from maurges June 17, 2024 13:54
maurges
maurges reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@maurges maurges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun, so the changelog script doesn't live well with rc versions

@survived
Copy link
Contributor Author

Yeah, but that doesn't happen very often that we have rc versions, so it's easier to ignore it than to update the script

@survived survived changed the title Update udigest to v0.2.0-rc2 Update udigest to v0.2.0-rc3 Jun 18, 2024
maurges
maurges previously approved these changes Jun 18, 2024
View reviewed changes
@survived
Copy link
Contributor Author

There's another release of udigest upcoming... I think it's better to update everything in bulk when udigest v0.2 is out

@survived survived marked this pull request as draft June 18, 2024 12:22
@survived survived dismissed maurges’s stale review June 18, 2024 12:22

PR will be updated

@survived survived changed the title Update udigest to v0.2.0-rc3 Update udigest Jun 18, 2024
@survived survived marked this pull request as ready for review June 20, 2024 07:23
@survived
Copy link
Contributor Author

@maurges updated deps so there's no rc versions anymore

@survived survived requested a review from maurges June 20, 2024 07:23
@survived survived merged commit 7a0ba4c into m Jun 20, 2024
23 of 26 checks passed
@survived survived deleted the update-udigest branch June 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurges maurges maurges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@survived @maurges