Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash to scalar primitive #40

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Add hash to scalar primitive #40

merged 4 commits into from
Jun 7, 2024

Conversation

survived
Copy link
Contributor

@survived survived commented Jun 6, 2024

Pipeline is failing because rand_hash repo is private. Pending approval to make it public. Upd: CI is working

@survived survived marked this pull request as draft June 6, 2024 11:27
@survived survived marked this pull request as ready for review June 6, 2024 11:29
@survived survived requested a review from maurges June 6, 2024 11:36
@maurges
Copy link
Contributor

maurges commented Jun 6, 2024

Pipeline is failing because rand_hash repo is private

How does it even work for you locally? Do you have some override to fetch from github?

@survived
Copy link
Contributor Author

survived commented Jun 6, 2024

Yep I have this in my ~/.gitconfig:

[url "ssh://git@github.com/dfns/rand_hash"]
	insteadOf = https://github.com/dfns/rand_hash

@survived
Copy link
Contributor Author

survived commented Jun 6, 2024

@maurges rand_hash was made public, CI is working

@maurges
Copy link
Contributor

maurges commented Jun 6, 2024

I think we should publish rand-hash before merging and publishing this one.

@survived
Copy link
Contributor Author

survived commented Jun 7, 2024

I think we should publish rand-hash before merging and publishing this one.

rand_hash is published, I updated the code to pull it from crates io

@survived survived merged commit 3bad73a into m Jun 7, 2024
24 of 26 checks passed
@survived survived deleted the hash-to-scalar branch June 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants