Add trusted dealer to key-share itself

[maurges]

Closes #78

Trusted dealer in cggmp now uses that for some calls.

Of note: when generating shares, we generated useless rid. I removed that.

[github-actions]

Crate direct deps

Direct deps

cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
digest v0.10.6
futures v0.3.24
generic-ec v0.1.3
generic-ec-zkp v0.1.1
hex v0.4.3
key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
paillier-zk v0.1.0
rand_chacha v0.3.1
rand_core v0.6.4
round-based v0.2.0
serde v1.0.188
serde_with v2.3.3
sha2 v0.10.6
thiserror v1.0.48
udigest v0.1.0

Compared to base branch

Diff

--- direct-deps-base	2024-02-22 13:47:38.483070507 +0000
+++ direct-deps-pr	2024-02-22 13:47:38.771070151 +0000
@@ -1 +1 @@
-cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -6,0 +7 @@
+key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)

All deps

cargo tree

cggmp21 v0.2.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21)
├── cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
│   ├── digest v0.10.6
│   │   ├── block-buffer v0.10.3
│   │   │   └── generic-array v0.14.6
│   │   │       ├── serde v1.0.188
│   │   │       │   └── serde_derive v1.0.188 (proc-macro)
│   │   │       │       ├── proc-macro2 v1.0.66
│   │   │       │       │   └── unicode-ident v1.0.4
│   │   │       │       ├── quote v1.0.33
│   │   │       │       │   └── proc-macro2 v1.0.66 (*)
│   │   │       │       └── syn v2.0.32
│   │   │       │           ├── proc-macro2 v1.0.66 (*)
│   │   │       │           ├── quote v1.0.33 (*)
│   │   │       │           └── unicode-ident v1.0.4
│   │   │       └── typenum v1.15.0
│   │   └── crypto-common v0.1.6
│   │       ├── generic-array v0.14.6 (*)
│   │       └── typenum v1.15.0
│   ├── futures v0.3.24
│   │   ├── futures-channel v0.3.24
│   │   │   ├── futures-core v0.3.24
│   │   │   └── futures-sink v0.3.24
│   │   ├── futures-core v0.3.24
│   │   ├── futures-executor v0.3.24
│   │   │   ├── futures-core v0.3.24
│   │   │   ├── futures-task v0.3.24
│   │   │   └── futures-util v0.3.24
│   │   │       ├── futures-channel v0.3.24 (*)
│   │   │       ├── futures-core v0.3.24
│   │   │       ├── futures-io v0.3.24
│   │   │       ├── futures-macro v0.3.24 (proc-macro)
│   │   │       │   ├── proc-macro2 v1.0.66 (*)
│   │   │       │   ├── quote v1.0.33 (*)
│   │   │       │   └── syn v1.0.101
│   │   │       │       ├── proc-macro2 v1.0.66 (*)
│   │   │       │       ├── quote v1.0.33 (*)
│   │   │       │       └── unicode-ident v1.0.4
│   │   │       ├── futures-sink v0.3.24
│   │   │       ├── futures-task v0.3.24
│   │   │       ├── memchr v2.5.0
│   │   │       ├── pin-project-lite v0.2.9
│   │   │       ├── pin-utils v0.1.0
│   │   │       └── slab v0.4.7
│   │   ├── futures-io v0.3.24
│   │   ├── futures-sink v0.3.24
│   │   ├── futures-task v0.3.24
│   │   └── futures-util v0.3.24 (*)
│   ├── generic-ec v0.1.3
│   │   ├── generic-ec-core v0.1.2
│   │   │   ├── generic-array v0.14.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   ├── serde v1.0.188 (*)
│   │   │   ├── subtle v2.4.1
│   │   │   └── zeroize v1.6.0
│   │   │       └── zeroize_derive v1.3.2 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.66 (*)
│   │   │           ├── quote v1.0.33 (*)
│   │   │           ├── syn v1.0.101 (*)
│   │   │           └── synstructure v0.12.6
│   │   │               ├── proc-macro2 v1.0.66 (*)
│   │   │               ├── quote v1.0.33 (*)
│   │   │               ├── syn v1.0.101 (*)
│   │   │               └── unicode-xid v0.2.4
│   │   ├── getrandom v0.2.10
│   │   │   ├── cfg-if v1.0.0
│   │   │   └── libc v0.2.148
│   │   ├── hex v0.4.3
│   │   │   └── serde v1.0.188 (*)
│   │   ├── phantom-type v0.4.2
│   │   │   └── educe v0.4.19 (proc-macro)
│   │   │       ├── enum-ordinalize v3.1.11 (proc-macro)
│   │   │       │   ├── num-bigint v0.4.3
│   │   │       │   │   ├── num-integer v0.1.45
│   │   │       │   │   │   └── num-traits v0.2.15
│   │   │       │   │   └── num-traits v0.2.15
│   │   │       │   ├── num-traits v0.2.15
│   │   │       │   ├── proc-macro2 v1.0.66 (*)
│   │   │       │   ├── quote v1.0.33 (*)
│   │   │       │   └── syn v1.0.101 (*)
│   │   │       ├── proc-macro2 v1.0.66 (*)
│   │   │       ├── quote v1.0.33 (*)
│   │   │       └── syn v1.0.101 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── serde v1.0.188 (*)
│   │   ├── serde_with v2.3.3
│   │   │   ├── serde v1.0.188 (*)
│   │   │   └── serde_with_macros v2.3.3 (proc-macro)
│   │   │       ├── darling v0.20.1
│   │   │       │   ├── darling_core v0.20.1
│   │   │       │   │   ├── fnv v1.0.7
│   │   │       │   │   ├── ident_case v1.0.1
│   │   │       │   │   ├── proc-macro2 v1.0.66 (*)
│   │   │       │   │   ├── quote v1.0.33 (*)
│   │   │       │   │   ├── strsim v0.10.0
│   │   │       │   │   └── syn v2.0.32 (*)
│   │   │       │   └── darling_macro v0.20.1 (proc-macro)
│   │   │       │       ├── darling_core v0.20.1 (*)
│   │   │       │       ├── quote v1.0.33 (*)
│   │   │       │       └── syn v2.0.32 (*)
│   │   │       ├── proc-macro2 v1.0.66 (*)
│   │   │       ├── quote v1.0.33 (*)
│   │   │       └── syn v2.0.32 (*)
│   │   ├── subtle v2.4.1
│   │   ├── udigest v0.1.0
│   │   │   ├── digest v0.10.6 (*)
│   │   │   └── udigest-derive v0.1.0 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.66 (*)
│   │   │       ├── quote v1.0.33 (*)
│   │   │       └── syn v2.0.32 (*)
│   │   └── zeroize v1.6.0 (*)
│   ├── generic-ec-zkp v0.1.1
│   │   ├── generic-array v0.14.6 (*)
│   │   ├── generic-ec v0.1.3 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── serde v1.0.188 (*)
│   │   ├── subtle v2.4.1
│   │   └── udigest v0.1.0 (*)
│   ├── hex v0.4.3 (*)
│   ├── key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
│   │   ├── generic-ec v0.1.3 (*)
│   │   ├── generic-ec-zkp v0.1.1 (*)
│   │   ├── hex v0.4.3 (*)
│   │   ├── serde v1.0.188 (*)
│   │   ├── serde_with v2.3.3 (*)
│   │   └── thiserror v1.0.48
│   │       └── thiserror-impl v1.0.48 (proc-macro)
│   │           ├── proc-macro2 v1.0.66 (*)
│   │           ├── quote v1.0.33 (*)
│   │           └── syn v2.0.32 (*)
│   ├── rand_core v0.6.4
│   ├── round-based v0.2.0
│   │   ├── futures-util v0.3.24 (*)
│   │   ├── phantom-type v0.3.1
│   │   │   └── educe v0.4.19 (proc-macro) (*)
│   │   ├── round-based-derive v0.2.0 (proc-macro)
│   │   │   ├── proc-macro2 v1.0.66 (*)
│   │   │   ├── quote v1.0.33 (*)
│   │   │   └── syn v1.0.101 (*)
│   │   ├── thiserror v1.0.48 (*)
│   │   └── tracing v0.1.36
│   │       ├── cfg-if v1.0.0
│   │       ├── pin-project-lite v0.2.9
│   │       ├── tracing-attributes v0.1.22 (proc-macro)
│   │       │   ├── proc-macro2 v1.0.66 (*)
│   │       │   ├── quote v1.0.33 (*)
│   │       │   └── syn v1.0.101 (*)
│   │       └── tracing-core v0.1.29
│   │           └── once_cell v1.17.0
│   ├── serde v1.0.188 (*)
│   ├── serde_with v2.3.3 (*)
│   ├── sha2 v0.10.6
│   │   ├── cfg-if v1.0.0
│   │   ├── cpufeatures v0.2.5
│   │   └── digest v0.10.6 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.1.0 (*)
├── digest v0.10.6 (*)
├── futures v0.3.24 (*)
├── generic-ec v0.1.3 (*)
├── generic-ec-zkp v0.1.1 (*)
├── hex v0.4.3 (*)
├── key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) (*)
├── paillier-zk v0.1.0
│   ├── digest v0.10.6 (*)
│   ├── fast-paillier v0.1.0
│   │   ├── bytemuck v1.13.1
│   │   │   └── bytemuck_derive v1.4.1 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.66 (*)
│   │   │       ├── quote v1.0.33 (*)
│   │   │       └── syn v2.0.32 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rug v1.21.0
│   │   │   ├── az v1.2.1
│   │   │   ├── gmp-mpfr-sys v1.6.1
│   │   │   │   └── libc v0.2.148
│   │   │   ├── libc v0.2.148
│   │   │   └── serde v1.0.188 (*)
│   │   ├── serde v1.0.188 (*)
│   │   └── thiserror v1.0.48 (*)
│   ├── generic-ec v0.1.3 (*)
│   ├── rand_core v0.6.4
│   ├── rug v1.21.0 (*)
│   ├── serde v1.0.188 (*)
│   ├── serde_with v3.0.0
│   │   ├── serde v1.0.188 (*)
│   │   └── serde_with_macros v3.0.0 (proc-macro)
│   │       ├── darling v0.20.1 (*)
│   │       ├── proc-macro2 v1.0.66 (*)
│   │       ├── quote v1.0.33 (*)
│   │       └── syn v2.0.32 (*)
│   └── thiserror v1.0.48 (*)
├── rand_chacha v0.3.1
│   ├── ppv-lite86 v0.2.17
│   └── rand_core v0.6.4
├── rand_core v0.6.4
├── round-based v0.2.0 (*)
├── serde v1.0.188 (*)
├── serde_with v2.3.3 (*)
├── sha2 v0.10.6 (*)
├── thiserror v1.0.48 (*)
└── udigest v0.1.0 (*)

Compared to base branch

Diff

--- all-deps-base	2024-02-22 13:47:38.619070339 +0000
+++ all-deps-pr	2024-02-22 13:47:38.903069989 +0000
@@ -6 +6 @@
-cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -34 +34 @@
-key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
+key-share v0.1.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)

[github-actions]

The spec was successfully compiled. PDF is available here.

[github-actions]

Benchmark Result

Benchmarks

RUST_TESTS_SEED=cba64ffb7d36dbd80dfa65f2e4d2222c7d63c0984473eeeb4702399057200d9f
n = 3

Non-threshold DKG
Protocol Performance:
  - Protocol took 425.88µs to complete
In particular:
  - Stage: 7.98µs
    - Setup networking: 7.78µs (97.6%)
    - Unstaged: 191.00ns (2.4%)
  - Round 1: 146.07µs
    - Compute execution id: 4.24µs (2.9%)
    - Sample x_i, rid_i, chain_code: 66.63µs (45.6%)
    - Sample schnorr commitment: 58.99µs (40.4%)
    - Commit to public data: 15.91µs (10.9%)
    - Unstaged: 301.00ns (0.2%)
  - Round 2: 2.64µs
    - Hash received msgs (reliability check): 2.46µs (93.2%)
    - Unstaged: 180.00ns (6.8%)
  - Round 3: 290.00ns
    - Assert other parties hashed messages (reliability check): 170.00ns (58.6%)
    - Unstaged: 120.00ns (41.4%)
  - Round 4: 33.11µs
    - Validate decommitments: 30.41µs (91.8%)
    - Calculate chain_code: 921.00ns (2.8%)
    - Calculate challege rid: 1.29µs (3.9%)
    - Prove knowledge of `x_i`: 321.00ns (1.0%)
    - Unstaged: 170.00ns (0.5%)
  - Round 5: 235.79µs
    - Validate schnorr proofs: 235.51µs (99.9%)
    - Unstaged: 280.00ns (0.1%)


Threshold DKG
Protocol Performance:
  - Protocol took 1.26ms to complete
In particular:
  - Stage: 1.78µs
    - Setup networking: 1.70µs (95.5%)
    - Unstaged: 81.00ns (4.5%)
  - Round 1: 201.67µs
    - Compute execution id: 781.00ns (0.4%)
    - Sample rid_i, schnorr commitment, polynomial, chain_code: 178.23µs (88.4%)
    - Commit to public data: 22.41µs (11.1%)
    - Unstaged: 241.00ns (0.1%)
  - Round 2: 1.13µs
    - Hash received msgs (reliability check): 952.00ns (84.2%)
    - Unstaged: 179.00ns (15.8%)
  - Round 3: 360.00ns
    - Assert other parties hashed messages (reliability check): 200.00ns (55.6%)
    - Unstaged: 160.00ns (44.4%)
  - Round 4: 784.20µs
    - Validate decommitments: 44.17µs (5.6%)
    - Validate data size: 300.00ns (0.0%)
    - Validate Feldmann VSS: 354.19µs (45.2%)
    - Compute rid: 211.00ns (0.0%)
    - Compute chain_code: 711.00ns (0.1%)
    - Compute Ys: 369.35µs (47.1%)
    - Compute sigma: 371.00ns (0.0%)
    - Calculate challenge: 14.35µs (1.8%)
    - Prove knowledge of `sigma_i`: 400.00ns (0.1%)
    - Unstaged: 141.00ns (0.0%)
  - Round 5: 265.87µs
    - Validate schnorr proofs: 264.38µs (99.4%)
    - Derive resulting public key and other data: 1.31µs (0.5%)
    - Unstaged: 170.00ns (0.1%)


Auxiliary data generation protocol
Protocol Performance:
  - Protocol took 9.51s to complete
In particular:
  - Stage: 10.72µs
    - Retrieve auxiliary data: 160.00ns (1.5%)
    - Setup networking: 9.64µs (89.9%)
    - Precompute execution id and shared state: 862.00ns (8.0%)
    - Unstaged: 60.00ns (0.6%)
  - Round 1: 1.16s
    - Retrieve primes (p and q): 80.00ns (0.0%)
    - Compute paillier decryption key (N): 8.33µs (0.0%)
    - Generate auxiliary params r, λ, t, s: 9.00ms (0.8%)
    - Prove Πprm (ψˆ_i): 1.15s (99.2%)
    - Sample random bytes: 1.86µs (0.0%)
    - Compute hash commitment and sample decommitment: 300.21µs (0.0%)
    - Unstaged: 230.00ns (0.0%)
  - Round 2: 1.73µs
    - Hash received msgs (reliability check): 1.00µs (57.8%)
    - Unstaged: 731.00ns (42.2%)
  - Round 3: 371.00ns
    - Assert other parties hashed messages (reliability check): 200.00ns (53.9%)
    - Unstaged: 171.00ns (46.1%)
  - Round 4: 5.87s
    - Validate round 1 decommitments: 596.86µs (0.0%)
    - Validate П_prm (ψ_i): 2.27s (38.7%)
    - Add together shared random bytes: 2.33µs (0.0%)
    - Compute П_mod (ψ_i): 3.43s (58.4%)
    - Assemble security params for П_fac (ф_i): 6.07µs (0.0%)
    - Compute П_fac (ф_i^j): 170.91ms (2.9%)
    - Unstaged: 1.18µs (0.0%)
  - Round 5: 2.48s
    - Validate ψ_j (П_mod): 2.31s (93.1%)
    - Validate ф_j (П_fac): 171.81ms (6.9%)
    - Assemble auxiliary info: 150.37µs (0.0%)
    - Unstaged: 881.00ns (0.0%)


Signing protocol
Protocol Performance:
  - Protocol took 4.16s to complete
In particular:
  - Stage: 138.20µs
    - Map t-out-of-n protocol to t-out-of-t: 65.20µs (47.2%)
    - Retrieve auxiliary data: 68.46µs (49.5%)
    - Precompute execution id and security params: 641.00ns (0.5%)
    - Setup networking: 3.82µs (2.8%)
    - Unstaged: 80.00ns (0.1%)
  - Round 1: 188.37ms
    - Generate local ephemeral secrets (k_i, y_i, p_i, v_i): 49.75µs (0.0%)
    - Encrypt G_i and K_i: 107.38ms (57.0%)
    - Prove ψ0_j: 80.94ms (43.0%)
    - Unstaged: 1.25µs (0.0%)
  - Round 2: 15.92µs
    - Hash received msgs (reliability check): 15.52µs (97.5%)
    - Unstaged: 401.00ns (2.5%)
  - Round 3: 2.22s
    - Assert other parties hashed messages (reliability check): 952.00ns (0.0%)
    - Verify psi0 proofs: 268.49ms (12.1%)
    - Sample random r, hat_r, s, hat_s, beta, hat_beta: 52.79µs (0.0%)
    - Encrypt D_ji: 70.26ms (3.2%)
    - Encrypt F_ji: 35.72ms (1.6%)
    - Encrypt hat_D_ji: 558.64ms (25.1%)
    - Encrypt hat_F_ji: 35.70ms (1.6%)
    - Prove psi_ji: 788.33ms (35.5%)
    - Prove psiˆ_ji: 209.18ms (9.4%)
    - Prove psi_prime_ji : 257.31ms (11.6%)
    - Unstaged: 2.76µs (0.0%)
  - Round 4: 1.56s
    - Retrieve auxiliary data: 5.68µs (0.0%)
    - Validate psi: 164.80ms (10.5%)
    - Validate hat_psi: 164.14ms (10.5%)
    - Validate psi_prime: 937.50ms (60.0%)
    - Compute Gamma, Delta_i, delta_i, chi_i: 214.96ms (13.8%)
    - Prove psi_prime_prime: 81.06ms (5.2%)
    - Unstaged: 631.00ns (0.0%)
  - Presig output: 184.78ms
    - Validate psi_prime_prime: 184.65ms (99.9%)
    - Calculate presignature: 135.04µs (0.1%)
    - Unstaged: 1.05µs (0.0%)
  - Partial signing: 9.99µs
  - Signature reconstruction: 201.57µs

[survived]

Could you also add reconstruct_secret_key to key_share? I guess, it would accept &[impl AsRef<CoreKeyShare<E>>] instead of &[impl AnyKeyShare<E>]

https://github.com/dfns/cggmp21/blob/09d96ab269fa7b2f3bcb311393b0ae47e8786f76/cggmp21/src/key_share.rs#L370-L372