Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cggmp24 #135

Merged
merged 13 commits into from
Jan 21, 2025
Merged

Update cggmp24 #135

merged 13 commits into from
Jan 21, 2025

Conversation

maurges
Copy link
Contributor

@maurges maurges commented Jan 21, 2025

Merge changes in m to cggmp24/m

ryjones and others added 12 commits January 9, 2025 08:25
@ryjones
chore: update actions
592cd64 
actions/upload-artifact and actions/download-artifact have
been deprecated and need updated.

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Signed-off-by: Ry Jones <ry@linux.com>
@ryjones
Merge pull request #129 from LFDT-Lockness/update-actions
ddd348d 
chore: update actions
@maurges
Batch p2p messages in one round instead of flushing immediately
9316928 
Signed-off-by: maurges <nikita@dfns.co>
@maurges
Fix nostd build with updated deps
3b41353 
Signed-off-by: maurges <nikita@dfns.co>
@maurges
Add batching to key refresh/aux gen. Return tracing
4469538 
Signed-off-by: maurges <nikita@dfns.co>
@maurges
Fix two-part rounds flushing too early
b61f767 
Signed-off-by: maurges <nikita@dfns.co>
@maurges
Use special non-flushing sink in tests
aefce3c 
Signed-off-by: maurges <nikita@dfns.co>
@maurges
Simplify and add comments
b2c7892 
Signed-off-by: maurges <nikita@dfns.co>
@maurges
Use newer round-based and it's features. Slight doc update
86dba6d 
Signed-off-by: maurges <nikita@dfns.co>
@maurges
Better docs for buffer-outgoing
f580ffa 
Signed-off-by: maurges <nikita@dfns.co>
@maurges
Merge pull request #127 from LFDT-Lockness/batch-send
5e621ac 
Batch p2p messages in one round instead of flushing immediately
@maurges
Merge branch 'm' into cggmp24/m
f2cd4c9
@maurges maurges requested a review from survived January 21, 2025 14:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

Crate direct deps

Direct deps 
cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
digest v0.10.6
futures v0.3.24
generic-ec v0.4.1
generic-ec-zkp v0.4.1
hex v0.4.3
key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
rand_core v0.6.4
rand_hash v0.1.0
round-based v0.4.1
serde v1.0.193
serde_with v2.3.3
sha2 v0.10.6
thiserror v1.0.48
udigest v0.2.1

Compared to base branch

Diff 
--- direct-deps-base	2025-01-21 15:21:00.160161712 +0000
+++ direct-deps-pr	2025-01-21 15:21:00.523166154 +0000
@@ -1 +1 @@
-cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -7,2 +7,2 @@
-key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
-paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/base_branch/paillier-zk)
+key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
+paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
@@ -11 +11 @@
-round-based v0.4.0
+round-based v0.4.1

All deps

cargo tree 
cggmp21 v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21)
├── cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
│   ├── digest v0.10.6
│   │   ├── block-buffer v0.10.3
│   │   │   └── generic-array v0.14.6
│   │   │       ├── serde v1.0.193
│   │   │       │   └── serde_derive v1.0.193 (proc-macro)
│   │   │       │       ├── proc-macro2 v1.0.92
│   │   │       │       │   └── unicode-ident v1.0.4
│   │   │       │       ├── quote v1.0.37
│   │   │       │       │   └── proc-macro2 v1.0.92 (*)
│   │   │       │       └── syn v2.0.90
│   │   │       │           ├── proc-macro2 v1.0.92 (*)
│   │   │       │           ├── quote v1.0.37 (*)
│   │   │       │           └── unicode-ident v1.0.4
│   │   │       └── typenum v1.15.0
│   │   └── crypto-common v0.1.6
│   │       ├── generic-array v0.14.6 (*)
│   │       └── typenum v1.15.0
│   ├── displaydoc v0.2.5 (proc-macro)
│   │   ├── proc-macro2 v1.0.92 (*)
│   │   ├── quote v1.0.37 (*)
│   │   └── syn v2.0.90 (*)
│   ├── futures-util v0.3.24
│   │   ├── futures-core v0.3.24
│   │   ├── futures-sink v0.3.24
│   │   ├── futures-task v0.3.24
│   │   ├── pin-project-lite v0.2.9
│   │   └── pin-utils v0.1.0
│   ├── generic-ec v0.4.1
│   │   ├── digest v0.10.6 (*)
│   │   ├── generic-ec-core v0.2.0
│   │   │   ├── generic-array v0.14.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   ├── serde v1.0.193 (*)
│   │   │   ├── subtle v2.4.1
│   │   │   └── zeroize v1.6.0
│   │   │       └── zeroize_derive v1.3.2 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.92 (*)
│   │   │           ├── quote v1.0.37 (*)
│   │   │           ├── syn v1.0.101
│   │   │           │   ├── proc-macro2 v1.0.92 (*)
│   │   │           │   ├── quote v1.0.37 (*)
│   │   │           │   └── unicode-ident v1.0.4
│   │   │           └── synstructure v0.12.6
│   │   │               ├── proc-macro2 v1.0.92 (*)
│   │   │               ├── quote v1.0.37 (*)
│   │   │               ├── syn v1.0.101 (*)
│   │   │               └── unicode-xid v0.2.4
│   │   ├── hex v0.4.3
│   │   │   └── serde v1.0.193 (*)
│   │   ├── phantom-type v0.4.2
│   │   │   └── educe v0.4.19 (proc-macro)
│   │   │       ├── enum-ordinalize v3.1.11 (proc-macro)
│   │   │       │   ├── num-bigint v0.4.3
│   │   │       │   │   ├── num-integer v0.1.45
│   │   │       │   │   │   └── num-traits v0.2.15
│   │   │       │   │   └── num-traits v0.2.15
│   │   │       │   ├── num-traits v0.2.15
│   │   │       │   ├── proc-macro2 v1.0.92 (*)
│   │   │       │   ├── quote v1.0.37 (*)
│   │   │       │   └── syn v1.0.101 (*)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v1.0.101 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rand_hash v0.1.0
│   │   │   ├── digest v0.10.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   └── udigest v0.2.1
│   │   │       ├── digest v0.10.6 (*)
│   │   │       └── udigest-derive v0.3.0 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.92 (*)
│   │   │           ├── quote v1.0.37 (*)
│   │   │           └── syn v2.0.90 (*)
│   │   ├── serde v1.0.193 (*)
│   │   ├── serde_with v2.3.3
│   │   │   ├── serde v1.0.193 (*)
│   │   │   └── serde_with_macros v2.3.3 (proc-macro)
│   │   │       ├── darling v0.20.1
│   │   │       │   ├── darling_core v0.20.1
│   │   │       │   │   ├── fnv v1.0.7
│   │   │       │   │   ├── ident_case v1.0.1
│   │   │       │   │   ├── proc-macro2 v1.0.92 (*)
│   │   │       │   │   ├── quote v1.0.37 (*)
│   │   │       │   │   ├── strsim v0.10.0
│   │   │       │   │   └── syn v2.0.90 (*)
│   │   │       │   └── darling_macro v0.20.1 (proc-macro)
│   │   │       │       ├── darling_core v0.20.1 (*)
│   │   │       │       ├── quote v1.0.37 (*)
│   │   │       │       └── syn v2.0.90 (*)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   ├── subtle v2.4.1
│   │   ├── udigest v0.2.1 (*)
│   │   └── zeroize v1.6.0 (*)
│   ├── generic-ec-zkp v0.4.1
│   │   ├── generic-array v0.14.6 (*)
│   │   ├── generic-ec v0.4.1 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── serde v1.0.193 (*)
│   │   ├── subtle v2.4.1
│   │   └── udigest v0.2.1 (*)
│   ├── hex v0.4.3 (*)
│   ├── key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
│   │   ├── displaydoc v0.2.5 (proc-macro) (*)
│   │   ├── generic-ec v0.4.1 (*)
│   │   ├── generic-ec-zkp v0.4.1 (*)
│   │   ├── hex v0.4.3 (*)
│   │   ├── serde v1.0.193 (*)
│   │   ├── serde_with v2.3.3 (*)
│   │   └── thiserror v1.0.48
│   │       └── thiserror-impl v1.0.48 (proc-macro)
│   │           ├── proc-macro2 v1.0.92 (*)
│   │           ├── quote v1.0.37 (*)
│   │           └── syn v2.0.90 (*)
│   ├── rand_core v0.6.4
│   ├── round-based v0.4.1
│   │   ├── futures-util v0.3.24 (*)
│   │   ├── phantom-type v0.3.1
│   │   │   └── educe v0.4.19 (proc-macro) (*)
│   │   ├── round-based-derive v0.2.2 (proc-macro)
│   │   │   ├── proc-macro2 v1.0.92 (*)
│   │   │   ├── quote v1.0.37 (*)
│   │   │   └── syn v1.0.101 (*)
│   │   ├── thiserror v2.0.4
│   │   │   └── thiserror-impl v2.0.4 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   └── tracing v0.1.36
│   │       ├── cfg-if v1.0.0
│   │       ├── pin-project-lite v0.2.9
│   │       └── tracing-core v0.1.29
│   ├── serde v1.0.193 (*)
│   ├── serde_with v2.3.3 (*)
│   ├── sha2 v0.10.6
│   │   ├── cfg-if v1.0.0
│   │   ├── cpufeatures v0.2.12
│   │   └── digest v0.10.6 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.2.1 (*)
├── digest v0.10.6 (*)
├── futures v0.3.24
│   ├── futures-channel v0.3.24
│   │   ├── futures-core v0.3.24
│   │   └── futures-sink v0.3.24
│   ├── futures-core v0.3.24
│   ├── futures-io v0.3.24
│   ├── futures-sink v0.3.24
│   ├── futures-task v0.3.24
│   └── futures-util v0.3.24 (*)
├── generic-ec v0.4.1 (*)
├── generic-ec-zkp v0.4.1 (*)
├── hex v0.4.3 (*)
├── key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) (*)
├── paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
│   ├── digest v0.10.6 (*)
│   ├── fast-paillier v0.1.0
│   │   ├── bytemuck v1.13.1
│   │   │   └── bytemuck_derive v1.4.1 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rug v1.21.0
│   │   │   ├── az v1.2.1
│   │   │   ├── gmp-mpfr-sys v1.6.1
│   │   │   │   └── libc v0.2.153
│   │   │   ├── libc v0.2.153
│   │   │   └── serde v1.0.193 (*)
│   │   ├── serde v1.0.193 (*)
│   │   └── thiserror v1.0.48 (*)
│   ├── generic-ec v0.4.1 (*)
│   ├── rand_core v0.6.4
│   ├── rand_hash v0.1.0 (*)
│   ├── rug v1.21.0 (*)
│   ├── serde v1.0.193 (*)
│   ├── serde_with v3.0.0
│   │   ├── serde v1.0.193 (*)
│   │   └── serde_with_macros v3.0.0 (proc-macro)
│   │       ├── darling v0.20.1 (*)
│   │       ├── proc-macro2 v1.0.92 (*)
│   │       ├── quote v1.0.37 (*)
│   │       └── syn v2.0.90 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.2.1 (*)
├── rand_core v0.6.4
├── rand_hash v0.1.0 (*)
├── round-based v0.4.1 (*)
├── serde v1.0.193 (*)
├── serde_with v2.3.3 (*)
├── sha2 v0.10.6 (*)
├── thiserror v1.0.48 (*)
└── udigest v0.2.1 (*)

Compared to base branch

Diff 
--- all-deps-base	2025-01-21 15:21:00.296163376 +0000
+++ all-deps-pr	2025-01-21 15:21:00.656167781 +0000
@@ -6 +6 @@
-cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -21 +20,0 @@
-futures-executor v0.3.24
@@ -23 +21,0 @@
-futures-macro v0.3.24 (proc-macro)
@@ -34 +32 @@
-key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
+key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
@@ -36 +33,0 @@
-memchr v2.5.0
@@ -40 +37 @@
-paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/base_branch/paillier-zk)
+paillier-zk v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
@@ -49 +46 @@
-round-based v0.4.0
+round-based v0.4.1
@@ -59 +55,0 @@
-slab v0.4.7

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

The spec was successfully compiled. PDF is available here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

Benchmark Result

Benchmarks 
RUST_TESTS_SEED=86f201046f2987ea5eb42484440d1ebe0d9d67c99539bd433c300f757dcd0228
n = 3

Non-threshold DKG
Protocol Performance:
  - Protocol took 419.28µs to complete
In particular:
  - Stage: 5.64µs
    - Setup networking: 5.33µs (94.5%)
    - Unstaged: 311.00ns (5.5%)
  - Round 1: 142.49µs
    - Sample x_i, rid_i, chain_code: 62.95µs (44.2%)
    - Sample schnorr commitment: 57.94µs (40.7%)
    - Commit to public data: 21.32µs (15.0%)
    - Unstaged: 281.00ns (0.2%)
  - Round 2: 1.31µs
    - Hash received msgs (reliability check): 1.11µs (84.8%)
    - Unstaged: 200.00ns (15.2%)
  - Round 3: 250.00ns
    - Assert other parties hashed messages (reliability check): 140.00ns (56.0%)
    - Unstaged: 110.00ns (44.0%)
  - Round 4: 35.78µs
    - Validate decommitments: 32.87µs (91.9%)
    - Calculate chain_code: 691.00ns (1.9%)
    - Calculate challege rid: 1.87µs (5.2%)
    - Prove knowledge of `x_i`: 221.00ns (0.6%)
    - Unstaged: 120.00ns (0.3%)
  - Round 5: 233.82µs
    - Validate schnorr proofs: 233.43µs (99.8%)
    - Unstaged: 391.00ns (0.2%)


Threshold DKG
Protocol Performance:
  - Protocol took 1.33ms to complete
In particular:
  - Stage: 1.93µs
    - Setup networking: 1.88µs (97.5%)
    - Unstaged: 49.00ns (2.5%)
  - Round 1: 200.10µs
    - Sample rid_i, schnorr commitment, polynomial, chain_code: 175.02µs (87.5%)
    - Commit to public data: 24.85µs (12.4%)
    - Unstaged: 240.00ns (0.1%)
  - Round 2: 1.24µs
    - Hash received msgs (reliability check): 1.09µs (87.9%)
    - Unstaged: 150.00ns (12.1%)
  - Round 3: 361.00ns
    - Assert other parties hashed messages (reliability check): 251.00ns (69.5%)
    - Unstaged: 110.00ns (30.5%)
  - Round 4: 800.12µs
    - Validate decommitments: 48.13µs (6.0%)
    - Validate data size: 370.00ns (0.0%)
    - Validate Feldmann VSS: 363.96µs (45.5%)
    - Compute rid: 150.00ns (0.0%)
    - Compute chain_code: 731.00ns (0.1%)
    - Compute Ys: 353.28µs (44.2%)
    - Compute sigma: 341.00ns (0.0%)
    - Calculate challenge: 32.69µs (4.1%)
    - Prove knowledge of `sigma_i`: 310.00ns (0.0%)
    - Unstaged: 160.00ns (0.0%)
  - Round 5: 322.38µs
    - Validate schnorr proofs: 320.93µs (99.5%)
    - Derive resulting public key and other data: 1.20µs (0.4%)
    - Unstaged: 250.00ns (0.1%)


Auxiliary data generation protocol
Protocol Performance:
  - Protocol took 9.59s to complete
In particular:
  - Stage: 16.74µs
    - Retrieve auxiliary data: 150.00ns (0.9%)
    - Setup networking: 16.49µs (98.5%)
    - Unstaged: 100.00ns (0.6%)
  - Round 1: 1.17s
    - Retrieve primes (p and q): 121.00ns (0.0%)
    - Compute paillier decryption key (N): 6.20µs (0.0%)
    - Generate auxiliary params r, λ, t, s: 9.01ms (0.8%)
    - Prove Πprm (ψˆ_i): 1.16s (99.2%)
    - Sample random bytes: 2.46µs (0.0%)
    - Compute hash commitment and sample decommitment: 304.29µs (0.0%)
    - Unstaged: 240.00ns (0.0%)
  - Round 2: 1.68µs
    - Hash received msgs (reliability check): 1.23µs (73.3%)
    - Unstaged: 450.00ns (26.7%)
  - Round 3: 360.00ns
    - Assert other parties hashed messages (reliability check): 190.00ns (52.8%)
    - Unstaged: 170.00ns (47.2%)
  - Round 4: 5.92s
    - Validate round 1 decommitments: 627.87µs (0.0%)
    - Validate П_prm (ψ_i): 2.30s (38.8%)
    - Add together shared random bytes: 1.47µs (0.0%)
    - Compute П_mod (ψ_i): 3.45s (58.3%)
    - Assemble security params for П_fac (ф_i): 14.94µs (0.0%)
    - Compute П_fac (ф_i^j): 172.01ms (2.9%)
    - Unstaged: 1.00µs (0.0%)
  - Round 5: 2.49s
    - Validate ψ_j (П_mod): 2.32s (93.1%)
    - Validate ф_j (П_fac): 173.05ms (6.9%)
    - Assemble auxiliary info: 143.67µs (0.0%)
    - Unstaged: 2.26µs (0.0%)


Signing protocol
Protocol Performance:
  - Protocol took 1.60s to complete
In particular:
  - Stage: 155.43µs
    - Map t-out-of-n protocol to t-out-of-t: 85.25µs (54.8%)
    - Retrieve auxiliary data: 65.66µs (42.2%)
    - Precompute execution id and security params: 631.00ns (0.4%)
    - Setup networking: 3.73µs (2.4%)
    - Unstaged: 161.00ns (0.1%)
  - Round 1: 117.58ms
    - Generate local ephemeral secrets (k_i, y_i, p_i, v_i): 48.19µs (0.0%)
    - Encrypt G_i and K_i: 36.01ms (30.6%)
    - Prove ψ0_j: 81.52ms (69.3%)
    - Unstaged: 533.00ns (0.0%)
  - Round 2: 15.94µs
    - Hash received msgs (reliability check): 15.58µs (97.7%)
    - Unstaged: 361.00ns (2.3%)
  - Round 3: 807.13ms
    - Assert other parties hashed messages (reliability check): 742.00ns (0.0%)
    - Verify psi0 proofs: 92.73ms (11.5%)
    - Sample random r, hat_r, s, hat_s, beta, hat_beta: 16.76µs (0.0%)
    - Encrypt D_ji: 70.74ms (8.8%)
    - Encrypt F_ji: 35.93ms (4.5%)
    - Encrypt hat_D_ji: 70.56ms (8.7%)
    - Encrypt hat_F_ji: 36.01ms (4.5%)
    - Prove psi_ji: 209.59ms (26.0%)
    - Prove psiˆ_ji: 209.80ms (26.0%)
    - Prove psi_prime_ji : 81.76ms (10.1%)
    - Unstaged: 3.41µs (0.0%)
  - Round 4: 577.76ms
    - Retrieve auxiliary data: 4.49µs (0.0%)
    - Validate psi: 165.10ms (28.6%)
    - Validate hat_psi: 165.21ms (28.6%)
    - Validate psi_prime: 92.88ms (16.1%)
    - Compute Gamma, Delta_i, delta_i, chi_i: 72.23ms (12.5%)
    - Prove psi_prime_prime: 82.34ms (14.3%)
    - Unstaged: 790.00ns (0.0%)
  - Presig output: 92.91ms
    - Validate psi_prime_prime: 92.77ms (99.9%)
    - Calculate presignature: 133.64µs (0.1%)
    - Unstaged: 1.34µs (0.0%)
  - Partial signing: 8.90µs
  - Signature reconstruction: 196.95µs

@survived
Update workflows
aaa1b2c 
Signed-off-by: Denis Varlakov <denis@dfns.co>
@maurges maurges merged commit 4b00e86 into cggmp24/m Jan 21, 2025
21 checks passed
@maurges maurges deleted the update-cggmp24 branch January 21, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@survived survived survived approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maurges @survived @ryjones