chore: update actions #129

ryjones · 2025-01-08T21:38:49Z

actions/upload-artifact and actions/download-artifact have been deprecated and need updated.

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

github-actions · 2025-01-08T21:40:18Z

The spec was successfully compiled. PDF is available here.

github-actions · 2025-01-08T21:42:20Z

Benchmark Result

Benchmarks

RUST_TESTS_SEED=a48ea68eed1d60ef3a73b6ba71d2fcb7f1b08908e17cec941c32db69a4047fe1
n = 3

Non-threshold DKG
Protocol Performance:
  - Protocol took 424.98µs to complete
In particular:
  - Stage: 6.23µs
    - Setup networking: 5.97µs (95.8%)
    - Unstaged: 261.00ns (4.2%)
  - Round 1: 146.33µs
    - Sample x_i, rid_i, chain_code: 66.05µs (45.1%)
    - Sample schnorr commitment: 58.00µs (39.6%)
    - Commit to public data: 21.98µs (15.0%)
    - Unstaged: 301.00ns (0.2%)
  - Round 2: 1.30µs
    - Hash received msgs (reliability check): 1.11µs (85.4%)
    - Unstaged: 190.00ns (14.6%)
  - Round 3: 281.00ns
    - Assert other parties hashed messages (reliability check): 161.00ns (57.3%)
    - Unstaged: 120.00ns (42.7%)
  - Round 4: 36.10µs
    - Validate decommitments: 32.88µs (91.1%)
    - Calculate chain_code: 681.00ns (1.9%)
    - Calculate challege rid: 2.18µs (6.1%)
    - Prove knowledge of `x_i`: 211.00ns (0.6%)
    - Unstaged: 140.00ns (0.4%)
  - Round 5: 234.73µs
    - Validate schnorr proofs: 234.37µs (99.8%)
    - Unstaged: 361.00ns (0.2%)


Threshold DKG
Protocol Performance:
  - Protocol took 1.31ms to complete
In particular:
  - Stage: 1.71µs
    - Setup networking: 1.65µs (96.5%)
    - Unstaged: 60.00ns (3.5%)
  - Round 1: 211.93µs
    - Sample rid_i, schnorr commitment, polynomial, chain_code: 186.72µs (88.1%)
    - Commit to public data: 25.00µs (11.8%)
    - Unstaged: 210.00ns (0.1%)
  - Round 2: 1.28µs
    - Hash received msgs (reliability check): 1.13µs (88.3%)
    - Unstaged: 150.00ns (11.7%)
  - Round 3: 370.00ns
    - Assert other parties hashed messages (reliability check): 240.00ns (64.9%)
    - Unstaged: 130.00ns (35.1%)
  - Round 4: 792.85µs
    - Validate decommitments: 48.34µs (6.1%)
    - Validate data size: 270.00ns (0.0%)
    - Validate Feldmann VSS: 357.15µs (45.0%)
    - Compute rid: 221.00ns (0.0%)
    - Compute chain_code: 661.00ns (0.1%)
    - Compute Ys: 352.59µs (44.5%)
    - Compute sigma: 351.00ns (0.0%)
    - Calculate challenge: 32.71µs (4.1%)
    - Prove knowledge of `sigma_i`: 391.00ns (0.0%)
    - Unstaged: 170.00ns (0.0%)
  - Round 5: 299.83µs
    - Validate schnorr proofs: 298.53µs (99.6%)
    - Derive resulting public key and other data: 1.05µs (0.4%)
    - Unstaged: 250.00ns (0.1%)


Auxiliary data generation protocol
Protocol Performance:
  - Protocol took 9.60s to complete
In particular:
  - Stage: 17.96µs
    - Retrieve auxiliary data: 130.00ns (0.7%)
    - Setup networking: 17.75µs (98.8%)
    - Unstaged: 80.00ns (0.4%)
  - Round 1: 1.17s
    - Retrieve primes (p and q): 110.00ns (0.0%)
    - Compute paillier decryption key (N): 3.42µs (0.0%)
    - Generate auxiliary params r, λ, t, s: 9.04ms (0.8%)
    - Prove Πprm (ψˆ_i): 1.16s (99.2%)
    - Sample random bytes: 2.58µs (0.0%)
    - Compute hash commitment and sample decommitment: 411.94µs (0.0%)
    - Unstaged: 260.00ns (0.0%)
  - Round 2: 1.43µs
    - Hash received msgs (reliability check): 1.13µs (79.1%)
    - Unstaged: 300.00ns (20.9%)
  - Round 3: 361.00ns
    - Assert other parties hashed messages (reliability check): 221.00ns (61.2%)
    - Unstaged: 140.00ns (38.8%)
  - Round 4: 5.93s
    - Validate round 1 decommitments: 546.95µs (0.0%)
    - Validate П_prm (ψ_i): 2.31s (38.9%)
    - Add together shared random bytes: 1.14µs (0.0%)
    - Compute П_mod (ψ_i): 3.45s (58.2%)
    - Assemble security params for П_fac (ф_i): 6.73µs (0.0%)
    - Compute П_fac (ф_i^j): 172.26ms (2.9%)
    - Unstaged: 1.22µs (0.0%)
  - Round 5: 2.50s
    - Validate ψ_j (П_mod): 2.33s (93.1%)
    - Validate ф_j (П_fac): 173.20ms (6.9%)
    - Assemble auxiliary info: 147.45µs (0.0%)
    - Unstaged: 592.00ns (0.0%)


Signing protocol
Protocol Performance:
  - Protocol took 1.60s to complete
In particular:
  - Stage: 146.99µs
    - Map t-out-of-n protocol to t-out-of-t: 65.21µs (44.4%)
    - Retrieve auxiliary data: 76.97µs (52.4%)
    - Precompute execution id and security params: 531.00ns (0.4%)
    - Setup networking: 4.14µs (2.8%)
    - Unstaged: 130.00ns (0.1%)
  - Round 1: 117.58ms
    - Generate local ephemeral secrets (k_i, y_i, p_i, v_i): 48.57µs (0.0%)
    - Encrypt G_i and K_i: 35.99ms (30.6%)
    - Prove ψ0_j: 81.54ms (69.3%)
    - Unstaged: 681.00ns (0.0%)
  - Round 2: 14.24µs
    - Hash received msgs (reliability check): 13.82µs (97.0%)
    - Unstaged: 420.00ns (3.0%)
  - Round 3: 806.72ms
    - Assert other parties hashed messages (reliability check): 621.00ns (0.0%)
    - Verify psi0 proofs: 92.51ms (11.5%)
    - Sample random r, hat_r, s, hat_s, beta, hat_beta: 17.48µs (0.0%)
    - Encrypt D_ji: 70.67ms (8.8%)
    - Encrypt F_ji: 35.94ms (4.5%)
    - Encrypt hat_D_ji: 70.44ms (8.7%)
    - Encrypt hat_F_ji: 35.97ms (4.5%)
    - Prove psi_ji: 209.76ms (26.0%)
    - Prove psiˆ_ji: 209.81ms (26.0%)
    - Prove psi_prime_ji : 81.59ms (10.1%)
    - Unstaged: 3.56µs (0.0%)
  - Round 4: 578.08ms
    - Retrieve auxiliary data: 5.32µs (0.0%)
    - Validate psi: 165.44ms (28.6%)
    - Validate hat_psi: 165.54ms (28.6%)
    - Validate psi_prime: 93.14ms (16.1%)
    - Compute Gamma, Delta_i, delta_i, chi_i: 72.16ms (12.5%)
    - Prove psi_prime_prime: 81.80ms (14.2%)
    - Unstaged: 722.00ns (0.0%)
  - Presig output: 93.11ms
    - Validate psi_prime_prime: 92.97ms (99.9%)
    - Calculate presignature: 132.78µs (0.1%)
    - Unstaged: 942.00ns (0.0%)
  - Partial signing: 8.70µs
  - Signature reconstruction: 197.16µs

survived · 2025-01-09T12:42:53Z

Thanks for the PR! We have a policy that prevents us from merging unsigned commits @ryjones. Can you sign them? Or alternatively I can re-do PR with my commits

actions/upload-artifact and actions/download-artifact have been deprecated and need updated. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Signed-off-by: Ry Jones <ry@linux.com>

github-actions · 2025-01-09T16:26:07Z

Crate direct deps

Direct deps

cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
digest v0.10.6
futures v0.3.24
generic-ec v0.4.1
generic-ec-zkp v0.4.1
hex v0.4.3
key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
paillier-zk v0.4.1
rand_core v0.6.4
rand_hash v0.1.0
round-based v0.4.0
serde v1.0.193
serde_with v2.3.3
sha2 v0.10.6
thiserror v1.0.48
udigest v0.2.1

Compared to base branch

Diff

--- direct-deps-base	2025-01-09 16:26:06.084925832 +0000
+++ direct-deps-pr	2025-01-09 16:26:06.371930015 +0000
@@ -1 +1 @@
-cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -7 +7 @@
-key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
+key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)

All deps

cargo tree

cggmp21 v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21)
├── cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
│   ├── digest v0.10.6
│   │   ├── block-buffer v0.10.3
│   │   │   └── generic-array v0.14.6
│   │   │       ├── serde v1.0.193
│   │   │       │   └── serde_derive v1.0.193 (proc-macro)
│   │   │       │       ├── proc-macro2 v1.0.92
│   │   │       │       │   └── unicode-ident v1.0.4
│   │   │       │       ├── quote v1.0.37
│   │   │       │       │   └── proc-macro2 v1.0.92 (*)
│   │   │       │       └── syn v2.0.90
│   │   │       │           ├── proc-macro2 v1.0.92 (*)
│   │   │       │           ├── quote v1.0.37 (*)
│   │   │       │           └── unicode-ident v1.0.4
│   │   │       └── typenum v1.15.0
│   │   └── crypto-common v0.1.6
│   │       ├── generic-array v0.14.6 (*)
│   │       └── typenum v1.15.0
│   ├── displaydoc v0.2.5 (proc-macro)
│   │   ├── proc-macro2 v1.0.92 (*)
│   │   ├── quote v1.0.37 (*)
│   │   └── syn v2.0.90 (*)
│   ├── generic-ec v0.4.1
│   │   ├── digest v0.10.6 (*)
│   │   ├── generic-ec-core v0.2.0
│   │   │   ├── generic-array v0.14.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   ├── serde v1.0.193 (*)
│   │   │   ├── subtle v2.4.1
│   │   │   └── zeroize v1.6.0
│   │   │       └── zeroize_derive v1.3.2 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.92 (*)
│   │   │           ├── quote v1.0.37 (*)
│   │   │           ├── syn v1.0.101
│   │   │           │   ├── proc-macro2 v1.0.92 (*)
│   │   │           │   ├── quote v1.0.37 (*)
│   │   │           │   └── unicode-ident v1.0.4
│   │   │           └── synstructure v0.12.6
│   │   │               ├── proc-macro2 v1.0.92 (*)
│   │   │               ├── quote v1.0.37 (*)
│   │   │               ├── syn v1.0.101 (*)
│   │   │               └── unicode-xid v0.2.4
│   │   ├── hex v0.4.3
│   │   │   └── serde v1.0.193 (*)
│   │   ├── phantom-type v0.4.2
│   │   │   └── educe v0.4.19 (proc-macro)
│   │   │       ├── enum-ordinalize v3.1.11 (proc-macro)
│   │   │       │   ├── num-bigint v0.4.3
│   │   │       │   │   ├── num-integer v0.1.45
│   │   │       │   │   │   └── num-traits v0.2.15
│   │   │       │   │   └── num-traits v0.2.15
│   │   │       │   ├── num-traits v0.2.15
│   │   │       │   ├── proc-macro2 v1.0.92 (*)
│   │   │       │   ├── quote v1.0.37 (*)
│   │   │       │   └── syn v1.0.101 (*)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v1.0.101 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rand_hash v0.1.0
│   │   │   ├── digest v0.10.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   └── udigest v0.2.1
│   │   │       ├── digest v0.10.6 (*)
│   │   │       └── udigest-derive v0.3.0 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.92 (*)
│   │   │           ├── quote v1.0.37 (*)
│   │   │           └── syn v2.0.90 (*)
│   │   ├── serde v1.0.193 (*)
│   │   ├── serde_with v2.3.3
│   │   │   ├── serde v1.0.193 (*)
│   │   │   └── serde_with_macros v2.3.3 (proc-macro)
│   │   │       ├── darling v0.20.1
│   │   │       │   ├── darling_core v0.20.1
│   │   │       │   │   ├── fnv v1.0.7
│   │   │       │   │   ├── ident_case v1.0.1
│   │   │       │   │   ├── proc-macro2 v1.0.92 (*)
│   │   │       │   │   ├── quote v1.0.37 (*)
│   │   │       │   │   ├── strsim v0.10.0
│   │   │       │   │   └── syn v2.0.90 (*)
│   │   │       │   └── darling_macro v0.20.1 (proc-macro)
│   │   │       │       ├── darling_core v0.20.1 (*)
│   │   │       │       ├── quote v1.0.37 (*)
│   │   │       │       └── syn v2.0.90 (*)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   ├── subtle v2.4.1
│   │   ├── udigest v0.2.1 (*)
│   │   └── zeroize v1.6.0 (*)
│   ├── generic-ec-zkp v0.4.1
│   │   ├── generic-array v0.14.6 (*)
│   │   ├── generic-ec v0.4.1 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── serde v1.0.193 (*)
│   │   ├── subtle v2.4.1
│   │   └── udigest v0.2.1 (*)
│   ├── hex v0.4.3 (*)
│   ├── key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
│   │   ├── displaydoc v0.2.5 (proc-macro) (*)
│   │   ├── generic-ec v0.4.1 (*)
│   │   ├── generic-ec-zkp v0.4.1 (*)
│   │   ├── hex v0.4.3 (*)
│   │   ├── serde v1.0.193 (*)
│   │   ├── serde_with v2.3.3 (*)
│   │   └── thiserror v1.0.48
│   │       └── thiserror-impl v1.0.48 (proc-macro)
│   │           ├── proc-macro2 v1.0.92 (*)
│   │           ├── quote v1.0.37 (*)
│   │           └── syn v2.0.90 (*)
│   ├── rand_core v0.6.4
│   ├── round-based v0.4.0
│   │   ├── futures-util v0.3.24
│   │   │   ├── futures-channel v0.3.24
│   │   │   │   ├── futures-core v0.3.24
│   │   │   │   └── futures-sink v0.3.24
│   │   │   ├── futures-core v0.3.24
│   │   │   ├── futures-io v0.3.24
│   │   │   ├── futures-macro v0.3.24 (proc-macro)
│   │   │   │   ├── proc-macro2 v1.0.92 (*)
│   │   │   │   ├── quote v1.0.37 (*)
│   │   │   │   └── syn v1.0.101 (*)
│   │   │   ├── futures-sink v0.3.24
│   │   │   ├── futures-task v0.3.24
│   │   │   ├── memchr v2.5.0
│   │   │   ├── pin-project-lite v0.2.9
│   │   │   ├── pin-utils v0.1.0
│   │   │   └── slab v0.4.7
│   │   ├── phantom-type v0.3.1
│   │   │   └── educe v0.4.19 (proc-macro) (*)
│   │   ├── round-based-derive v0.2.2 (proc-macro)
│   │   │   ├── proc-macro2 v1.0.92 (*)
│   │   │   ├── quote v1.0.37 (*)
│   │   │   └── syn v1.0.101 (*)
│   │   ├── thiserror v2.0.4
│   │   │   └── thiserror-impl v2.0.4 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   └── tracing v0.1.36
│   │       ├── cfg-if v1.0.0
│   │       ├── pin-project-lite v0.2.9
│   │       └── tracing-core v0.1.29
│   ├── serde v1.0.193 (*)
│   ├── serde_with v2.3.3 (*)
│   ├── sha2 v0.10.6
│   │   ├── cfg-if v1.0.0
│   │   ├── cpufeatures v0.2.12
│   │   └── digest v0.10.6 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.2.1 (*)
├── digest v0.10.6 (*)
├── futures v0.3.24
│   ├── futures-channel v0.3.24 (*)
│   ├── futures-core v0.3.24
│   ├── futures-executor v0.3.24
│   │   ├── futures-core v0.3.24
│   │   ├── futures-task v0.3.24
│   │   └── futures-util v0.3.24 (*)
│   ├── futures-io v0.3.24
│   ├── futures-sink v0.3.24
│   ├── futures-task v0.3.24
│   └── futures-util v0.3.24 (*)
├── generic-ec v0.4.1 (*)
├── generic-ec-zkp v0.4.1 (*)
├── hex v0.4.3 (*)
├── key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) (*)
├── paillier-zk v0.4.1
│   ├── digest v0.10.6 (*)
│   ├── fast-paillier v0.1.0
│   │   ├── bytemuck v1.13.1
│   │   │   └── bytemuck_derive v1.4.1 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.92 (*)
│   │   │       ├── quote v1.0.37 (*)
│   │   │       └── syn v2.0.90 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rug v1.21.0
│   │   │   ├── az v1.2.1
│   │   │   ├── gmp-mpfr-sys v1.6.1
│   │   │   │   └── libc v0.2.153
│   │   │   ├── libc v0.2.153
│   │   │   └── serde v1.0.193 (*)
│   │   ├── serde v1.0.193 (*)
│   │   └── thiserror v1.0.48 (*)
│   ├── generic-ec v0.4.1 (*)
│   ├── rand_core v0.6.4
│   ├── rand_hash v0.1.0 (*)
│   ├── rug v1.21.0 (*)
│   ├── serde v1.0.193 (*)
│   ├── serde_with v3.0.0
│   │   ├── serde v1.0.193 (*)
│   │   └── serde_with_macros v3.0.0 (proc-macro)
│   │       ├── darling v0.20.1 (*)
│   │       ├── proc-macro2 v1.0.92 (*)
│   │       ├── quote v1.0.37 (*)
│   │       └── syn v2.0.90 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.2.1 (*)
├── rand_core v0.6.4
├── rand_hash v0.1.0 (*)
├── round-based v0.4.0 (*)
├── serde v1.0.193 (*)
├── serde_with v2.3.3 (*)
├── sha2 v0.10.6 (*)
├── thiserror v1.0.48 (*)
└── udigest v0.2.1 (*)

Compared to base branch

Diff

--- all-deps-base	2025-01-09 16:26:06.222927843 +0000
+++ all-deps-pr	2025-01-09 16:26:06.511932056 +0000
@@ -6 +6 @@
-cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.5.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -34 +34 @@
-key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
+key-share v0.6.0 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)

ryjones · 2025-01-09T16:26:17Z

@survived I added your changes to my commit

survived · 2025-01-10T13:17:09Z

It's strange that my review was not dismissed after you pushed a new commit despite the protection settings of the branch. Probably a github bug?

survived · 2025-01-10T13:17:51Z

The diff is the same as approved one, so maybe github didn't treat the new commit as something that should dismiss the review approval

ryjones · 2025-01-10T16:34:31Z

@survived I updated [the ruleset](https://github.com/LFDT

-Lockness/cggmp21/settings/rules/2940679)

survived · 2025-01-10T17:41:52Z

I don't think it will work actually, all it do (from my experience) is that if I do the most recent push, I can't approve PR

survived · 2025-01-10T17:42:40Z

in this case, you did the most recent push, I did the review, this policy does not apply (I also think it has confusing name)

ryjones requested review from maurges and survived and removed request for maurges January 8, 2025 21:50

survived changed the base branch from m to cggmp24/m January 9, 2025 12:31

survived changed the base branch from cggmp24/m to m January 9, 2025 12:40

survived approved these changes Jan 9, 2025

View reviewed changes

chore: update actions

592cd64

actions/upload-artifact and actions/download-artifact have been deprecated and need updated. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Signed-off-by: Ry Jones <ry@linux.com>

ryjones force-pushed the update-actions branch from 6a5f761 to 592cd64 Compare January 9, 2025 16:25

ryjones merged commit ddd348d into m Jan 9, 2025
19 checks passed

ryjones deleted the update-actions branch January 9, 2025 17:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update actions #129

chore: update actions #129

ryjones commented Jan 8, 2025

github-actions bot commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

survived commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025

ryjones commented Jan 9, 2025

survived commented Jan 10, 2025

survived commented Jan 10, 2025

ryjones commented Jan 10, 2025 •

edited

Loading

survived commented Jan 10, 2025

survived commented Jan 10, 2025

chore: update actions #129

chore: update actions #129

Conversation

ryjones commented Jan 8, 2025

github-actions bot commented Jan 8, 2025 • edited Loading

github-actions bot commented Jan 8, 2025 • edited Loading

Benchmark Result

survived commented Jan 9, 2025 • edited Loading

github-actions bot commented Jan 9, 2025

Crate direct deps

Compared to base branch

All deps

Compared to base branch

ryjones commented Jan 9, 2025

survived commented Jan 10, 2025

survived commented Jan 10, 2025

ryjones commented Jan 10, 2025 • edited Loading

survived commented Jan 10, 2025

survived commented Jan 10, 2025

github-actions bot commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

survived commented Jan 9, 2025 •

edited

Loading

ryjones commented Jan 10, 2025 •

edited

Loading